Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: miscompilation in pointer operations [1.18 backport] #52961

Open
gopherbot opened this issue May 18, 2022 · 2 comments
Open

cmd/compile: miscompilation in pointer operations [1.18 backport] #52961

gopherbot opened this issue May 18, 2022 · 2 comments
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 18, 2022

@bcmills requested issue #52953 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.17 and 1.18. This bug causes miscompilation of otherwise-correct Go programs.

@gopherbot gopherbot added the CherryPickCandidate label May 18, 2022
@gopherbot gopherbot added this to the Go1.18.3 milestone May 18, 2022
@randall77
Copy link
Contributor

@randall77 randall77 commented May 18, 2022

I'm not sure this needs backporting. The bug was only found by fuzzing the compiler, not in a real program. The code to trigger it is unusual (reinitializing a variable using a pointer to that very same variable), and easily worked around.

That said, the fix is pretty safe, and if you do hit the bug it causes incorrect behavior.

@bcmills
Copy link
Member

@bcmills bcmills commented May 18, 2022

The bug was only found by fuzzing the compiler, not in a real program. The code to trigger it is unusual (reinitializing a variable using a pointer to that very same variable), and easily worked around.

That may be true, but the behavior is also pretty subtle — I wouldn't be at all surprised if there are a few real-world programs that do trigger it but don't notice the incorrect behavior, and of course we don't have any way to identify them if they're still on an older Go release.

@dmitshur dmitshur removed this from the Go1.18.3 milestone Jun 1, 2022
@dmitshur dmitshur added this to the Go1.18.4 milestone Jun 1, 2022
@heschi heschi added the CherryPickApproved label Jun 15, 2022
@gopherbot gopherbot removed the CherryPickCandidate label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

5 participants