Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: switch to new diff implementation (umbrella) #52967

Open
5 tasks
findleyr opened this issue May 18, 2022 · 0 comments
Open
5 tasks

x/tools/gopls: switch to new diff implementation (umbrella) #52967

findleyr opened this issue May 18, 2022 · 0 comments
Assignees
Labels
gopls Tools umbrella
Milestone

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented May 18, 2022

This is an umbrella issue tracking the work to switch to the new diff implementation being worked on by @pjweinb in https://go.dev/cl/396855.

Rough outline of steps:

  • #52966: Land the new implementation, with the "both" algorithm option comparing old and new.
  • Run this for a week or so among the team or any early adopters.
  • Enable "both" on the vscode-go nightly release, with bug reporting enabled.
  • Make the new diff algorithm the default, with an option to revert to the old diff algorithm.
  • Remove the old diff algorithm, and the dependency on go-diff.
@findleyr findleyr added this to the gopls/later milestone May 18, 2022
@gopherbot gopherbot added Tools gopls labels May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Tools umbrella
Projects
None yet
Development

No branches or pull requests

3 participants