Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: drop support for building at Go 1.13 #52982

Open
4 tasks
findleyr opened this issue May 18, 2022 · 0 comments
Open
4 tasks

x/tools/gopls: drop support for building at Go 1.13 #52982

findleyr opened this issue May 18, 2022 · 0 comments
Labels
gopls Tools
Milestone
gopls/later

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented May 18, 2022

As described in our support documentation, gopls only supports building with the last four Go versions.

#50825 outlines a long-term plan to remove support for building gopls at legacy Go versions, but in the meantime we should drop support for Go 1.13 and Go 1.14 now that Go 1.18 is released. This issue tracks dropping support for 1.13.

Action items:

  • note the end-of-life for Go 1.13 support in our v0.8.4 release notes
  • check with the VS Code team to update our compatibility matrix
  • document our new compatibility matrix.
  • remove Kokoro 1.13 CI

CC @hyangah
@gopherbot gopherbot added Tools gopls labels May 18, 2022
@gopherbot gopherbot added this to the Unreleased milestone May 18, 2022
@findleyr findleyr removed this from the Unreleased milestone May 18, 2022
@findleyr findleyr added this to the gopls/v0.9.0 milestone May 18, 2022
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 28, 2022
gopls: update to 0.8.4.
373c366 
New Features

New analyzer for //go:embed comments

Gopls now includes an analyzer for go:embed comment directives. At
the moment, this analyzer checks that the "embed" import is present,
but more analyses are planned for the future. See golang/go#50262
for more information.

Improved hover for imports

Hovering over an imported path now gives you the full package doc.

Final support for Go 1.13

Per our support window, gopls v0.8.4 will be the final gopls release
to support being built with Go 1.13. See golang/go#52982 for details.

Bugfixes and Performance improvements

    Faster symbol indexing. Gopls builds a symbol index the first
    time symbol search is invoked. That indexing should be 3-4x
    faster with this release.

    Improved metadata invalidation (AKA fewer restarts). v0.8.4
    fixes a couple of bugs that lead to gopls getting confused
    about packages and needing to be restarted. We're aware of more
    bugs of this nature, but are working on eliminating the need
    to ever restart gopls.
@findleyr findleyr removed this from the gopls/v0.9.0 milestone Jun 13, 2022
@findleyr findleyr added this to the gopls/later milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Tools
Projects
None yet
Milestone
gopls/later
Development

No branches or pull requests
2 participants
@gopherbot @findleyr