-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/http2: TestTransportGroupsPendingDials failures due to missing Close #52996
Comments
This failure mode has been observed on (If this isn't a priority to fix, a skip can be added to the test for this failure mode and then the issue can be moved to the backlog.) |
Change https://go.dev/cl/411294 mentions this issue: |
I'm not sure what's going on here. This is not #50027: This test is expecting The only thing that makes sense is that a request has stayed live past Flakes are super rare, and I haven't managed to reproduce it. Sent a CL to enable verbose HTTP/2 logging during this test; perhaps that'll point us at the problem the next time this flakes. |
Removing the release-blocker label: If there's a real underlying issue, it does not need to block the release. CL 411294 will hopefully let us collect more information towards resolving the flake. |
This test is very, very rarely flaky. Enable additional logs to help debug what's going on. For golang/go#52996. Change-Id: Ibccbfff94f51d2c813d48b48077537090bea4612 Reviewed-on: https://go-review.googlesource.com/c/net/+/411294 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Rolling forward to 1.20. Please comment if you disagree. Thanks. |
This test is very, very rarely flaky. Enable additional logs to help debug what's going on. For golang/go#52996. Change-Id: Ibccbfff94f51d2c813d48b48077537090bea4612 Reviewed-on: https://go-review.googlesource.com/c/net/+/411294 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
greplogs -l -e 'FAIL: TestTransportGroupsPendingDials .*(?:\n[ ]{4}.*) saw 0 closes' --since=2021-01-01
2022-05-18T15:25:04-183a9ca-1f9f7db/linux-amd64-clang
2022-04-29T02:01:27-2871e0c-e7c56fe/freebsd-arm-paulzhol
2022-03-04T14:10:38-27dd868-c9b6063/freebsd-arm64-dmgk
This may be a symptom of #50027; see previously #43176.
(attn @neild @tombergan)
The text was updated successfully, but these errors were encountered: