Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: unexpected trampoline error on ppc64le musl with -buildmode=pie [1.18 backport] #53107

Open
gopherbot opened this issue May 27, 2022 · 3 comments
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 27, 2022

@pmur requested issue #52337 to be considered for backport to the next 1.18 minor release.

Hi @sergiodj, I'll check to make sure there aren't any soft-dependencies which also need backported. That test is one which forces trampoline generation while using -buildmode=pie. Maybe this is enough justification for a backport?

@gopherbot please consider this for backporting to 1.18.

@gopherbot gopherbot added the CherryPickCandidate label May 27, 2022
@gopherbot gopherbot added this to the Go1.18.3 milestone May 27, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 27, 2022

Change https://go.dev/cl/409074 mentions this issue: [release-branch.go1.18] cmd/link: use TOC-relative trampolines on PPC64 when needed

@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 27, 2022

Change https://go.dev/cl/409075 mentions this issue: [release-branch.go1.18] cmd/link: use TOC-relative trampolines on PPC64 when needed

@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 27, 2022

Change https://go.dev/cl/408820 mentions this issue: [release-branch.go1.18] cmd/link: preserve symbol attributes when cloning to external

@dmitshur dmitshur changed the title cmd/go: unexpected trampoline error on ppc64le musl with -buildmode=pie [1.18 backport] cmd/link: unexpected trampoline error on ppc64le musl with -buildmode=pie [1.18 backport] Jun 1, 2022
@dmitshur dmitshur removed this from the Go1.18.3 milestone Jun 1, 2022
@dmitshur dmitshur added this to the Go1.18.4 milestone Jun 1, 2022
@heschi heschi added the CherryPickApproved label Jun 15, 2022
@gopherbot gopherbot removed the CherryPickCandidate label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

3 participants