Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go test -buildvcs=true does not include vcs information [1.18 backport] #53177

Closed
gopherbot opened this issue Jun 1, 2022 · 1 comment
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #52648 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.18. The requested -buildvcs behavior for this particular use-case was present in Go 1.18, but regressed in Go 1.18.1 as a byproduct of the fix for #51767. Now that -buildvcs=auto has been added for #51798, the Go 1.18 behavior for -buildvcs=true can be restored.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 1, 2022
@gopherbot gopherbot added this to the Go1.18.3 milestone Jun 1, 2022
@dmitshur dmitshur modified the milestones: Go1.18.3, Go1.18.4 Jun 1, 2022
@joedian joedian added the GoCommand cmd/go label Jun 22, 2022
@gopherbot gopherbot modified the milestones: Go1.18.4, Go1.18.5 Jul 12, 2022
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jul 13, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 13, 2022
@gopherbot gopherbot modified the milestones: Go1.18.5, Go1.18.6 Aug 1, 2022
@bcmills bcmills added CherryPickCandidate Used during the release process for point releases and removed CherryPickApproved Used during the release process for point releases labels Sep 6, 2022
@gopherbot gopherbot modified the milestones: Go1.18.6, Go1.18.7 Sep 6, 2022
@bcmills
Copy link
Member

bcmills commented Sep 9, 2022

At this point I think this is esoteric enough not to backport, and we've already had enough churn in the -buildvcs behavior of Go 1.18. Let's just leave it for the regular release in Go 1.20.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2022
@golang golang locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Development

No branches or pull requests

4 participants