crypto/tls: superfluous "return" in generate_cert.go

[JeremyRand]

What version of Go are you using (go version)?

Git 46ab7a5

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

linux/ppc64le, but that seems inapplicable to this issue.

What did you do?

Read the source for generate_cert.go, saw what looks like a superfluous return.

go/src/crypto/tls/generate_cert.go

Lines 157 to 160 in 46ab7a5

	if err != nil {
	log.Fatalf("Failed to open key.pem for writing: %v", err)
	return
	}

What did you expect to see?

	if err != nil {
		log.Fatalf("Failed to open key.pem for writing: %v", err)
	}

No return, since log.Fatalf makes it unnecessary, just like in the rest of the file.

What did you see instead?

	if err != nil {
		log.Fatalf("Failed to open key.pem for writing: %v", err)
		return
	}

The return seems unnecessary, and doesn't match the style in the rest of the file when log.Fatalf is used.

[dmitshur]

Thanks for reporting. This is a valid issue, albeit very minor. Please feel free to mail a change that removes the extra return, since it's indeed not needed and inconsistent. (It's also okay to mail a CL right away for an issue like this.) Thanks.

[gopherbot]

Change https://go.dev/cl/420935 mentions this issue: crypto: delete unnecessary line of return