Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support pull-based diagnostics available in LSP 3.17 #53275

Open
hyangah opened this issue Jun 7, 2022 · 0 comments
Open

x/tools/gopls: support pull-based diagnostics available in LSP 3.17 #53275

hyangah opened this issue Jun 7, 2022 · 0 comments
Labels
FeatureRequest gopls/analysis gopls Tools
Milestone

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Jun 7, 2022

LSP 3.17 adds support for Pull Diagnostics

The spec includes Document Diagnostics, Workspace Diagnostics.

I think this allows us to address some long-standing issues like

  • golang/vscode-go#50 Support a setting to control the frequency of diagnostics
    (some users want to see diagnostics only when they save a file, not as they type
  • golang/vscode-go#1275 Option to run diagnostics only on current package

Partly

  • #42527 Support diagnostics for files inside vendor directories
  • #45607 (comment) Fine-grained control on diagnostics
@hyangah hyangah added FeatureRequest gopls/analysis labels Jun 7, 2022
@gopherbot gopherbot added Tools gopls labels Jun 7, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jun 7, 2022
@jamalc jamalc removed this from the Unreleased milestone Jun 8, 2022
@jamalc jamalc added this to the gopls/later milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest gopls/analysis gopls Tools
Projects
None yet
Development

No branches or pull requests

3 participants