Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: error messages sometimes use x|y and sometimes x | y for union terms #53279

Open
griesemer opened this issue Jun 7, 2022 · 7 comments
Assignees
Labels
NeedsFix
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Jun 7, 2022

Reminder issue: Should use consistent spacing for union terms in error messages.

@griesemer griesemer added the NeedsFix label Jun 7, 2022
@griesemer griesemer added this to the Go1.19 milestone Jun 7, 2022
@griesemer griesemer self-assigned this Jun 7, 2022
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Jun 7, 2022

cc: @findleyr

@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Jun 7, 2022

Decision: use x | y to match gofmt.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 7, 2022

Change https://go.dev/cl/410955 mentions this issue: go/types, types2: consistently write "x | y" rather than "x|y" for unions

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 7, 2022

Change https://go.dev/cl/410994 mentions this issue: internal: re-enable adjusted tests

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 7, 2022

Change https://go.dev/cl/410956 mentions this issue: internal: temporarily disable tests so we can land CL 410955

gopherbot pushed a commit to golang/tools that referenced this issue Jun 8, 2022
For golang/go#53279.

Change-Id: I3e0a502f8f0789ff9920af504ea8c86812bf49a1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/410956
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 24, 2022

@griesemer Anything left to do for this issue? Thanks.

@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Jun 24, 2022

CLs are present but I ran into problems with x/tools. Will try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix
Projects
Status: No status
Development

No branches or pull requests

3 participants