Repository navigation
x/sys: missing rcx in clobber list for gccgoXgetbv #53302
Description
The inline assembly in gccgoXgetbv (https://cs.opensource.google/go/x/sys/+/master:cpu/cpu_gccgo_x86.c;l=40) modifies rcx but forgets to add rcx to the clobber list. We have encountered a crash when building an application with GOLLVM (and setting CC to clang-11.
void
gccgoXgetbv(uint32_t *eax, uint32_t *edx)
{
__asm(" xorl %%ecx, %%ecx\n"
" xgetbv"
: "=a"(*eax), "=d"(*edx));
}
Activity
cherrymui commentedon Jun 9, 2022
cc @thanm @ianlancetaylor
gopherbot commentedon Jun 10, 2022
Change https://go.dev/cl/411635 mentions this issue:
cpu: use xgetbv intrinsiccpu: use xgetbv intrinsic