x/tools/gopls: Default setting of GOPROXY=off causes problems with downloading modules

[Jefftree]

gopls version

golang.org/x/tools/gopls v0.7.5
    golang.org/x/tools/gopls@v0.7.5 h1:8Az52YwcFXTWPvrRomns1C0N+zlgTyyPKWvRazO9GG8=

go env

What did you do?

Hi, I recently upgraded from a gopls version from over a year ago (0.1.0). I was getting an error module lookup disabled by GOPROXY=off but my project (kubernetes) has no private repos. (It does use a mod file with replace directives and a vendor directory).

As a fix, I was able to fix the problem via toggling allowImplicitNetworkAccess, but it looks like this is not recommended. I'm not sure if this is a problem with my environment or the go.mod for Kubernetes (everything works smoothly for other repos).

Editor and settings

Emacs, using lsp-mode and gopls

Logs

[jamalc]

Is this a problem only when the mod file changes or during startup as well?

[Jefftree]

startup as well

[findleyr]

Hmm, the initial workspace load is supposed to allow network access.

Also: does go build succeed from the command line?

Could you share logs from your gopls session?
https://github.com/golang/tools/blob/master/gopls/doc/troubleshooting.md#capture-logs

[rski]

for what it's worth, NixOS/nixpkgs#177632 was diagnosed to be due to dns resolution issues. I will open another issue because the error ends up being misleading and that is a problem of itself, but maybe there are dns issues going on here too?

[dle8]

@Jefftree: can you respond to @findleyr questions? Also is this the dns issue in your case like @rski mentioned?