Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add source test for inlay hints #53315

Open
suzmue opened this issue Jun 9, 2022 · 2 comments
Open

x/tools/gopls: add source test for inlay hints #53315

suzmue opened this issue Jun 9, 2022 · 2 comments
Labels
gopls Tools
Milestone

Comments

@suzmue
Copy link
Contributor

@suzmue suzmue commented Jun 9, 2022

Track progress of source tests for inlay hints.

@gopherbot gopherbot added Tools gopls labels Jun 9, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jun 9, 2022
@sidntrivedi012
Copy link

@sidntrivedi012 sidntrivedi012 commented Jun 9, 2022

Hey @suzmue 👋 , would like to help out with this issue. Would be great if you can please provide some more context regarding what needs to be done here. Thanks! 🙌

@suzmue suzmue removed this from the Unreleased milestone Jun 13, 2022
@suzmue suzmue added this to the gopls/later milestone Jun 13, 2022
@suzmue
Copy link
Contributor Author

@suzmue suzmue commented Jun 13, 2022

With the addition of features that are exposed through inlay hints, we may want to add source tests for these features (code pointer here).

These tests would need to call the source package's implementation here.

The lsp tests currently take the approach of getting the inlay hints for the whole file and then applying them to the document as if they were text edits. It will probably require some additional set up to be able to track what inlay hints we are expecting from these source tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Tools
Projects
None yet
Development

No branches or pull requests

3 participants