Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: missing combine constant store cases on amd64 #53324

Open
wdvxdr1123 opened this issue Jun 10, 2022 · 1 comment
Open

cmd/compile: missing combine constant store cases on amd64 #53324

wdvxdr1123 opened this issue Jun 10, 2022 · 1 comment
Labels
NeedsInvestigation Performance
Milestone

Comments

@wdvxdr1123
Copy link
Contributor

@wdvxdr1123 wdvxdr1123 commented Jun 10, 2022

What version of Go are you using (go version)?

gotip

What did you do?

func a(b []byte, idx int) {
	binary.LittleEndian.PutUint64(b[idx:], 123)
}

What did you expect to see?

MOVQ $123, (AX)(DX*1)

What did you see instead?

MOVB $123, (AX)(DI*1)
MOVB $0, 1(AX)(DI*1)
MOVB $0, 2(AX)(DI*1)
MOVB $0, 3(AX)(DI*1)
MOVB $0, 4(AX)(DI*1)
MOVB $0, 5(AX)(DI*1)
MOVB $0, 6(AX)(DI*1)
MOVB $0, 7(AX)(DI*1)
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 10, 2022

Change https://go.dev/cl/411614 mentions this issue: cmd/compile: combine more constant stores on amd64

@cherrymui cherrymui added Performance NeedsInvestigation labels Jun 10, 2022
@cherrymui cherrymui added this to the Unplanned milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Performance
Projects
None yet
Development

No branches or pull requests

3 participants