Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestTransportReuseConnection_Gzip_ContentLength failure with "didn't reuse connection" on freebsd-amd64-race #53373

Open
bcmills opened this issue Jun 14, 2022 · 3 comments
Assignees
Labels
help wanted NeedsInvestigation OS-FreeBSD
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jun 14, 2022

2022/06/08 19:53:00 http: TLS handshake error from 127.0.0.1:21458: EOF
--- FAIL: TestTransportReuseConnection_Gzip_ContentLength (0.10s)
    transport_test.go:4447: didn't reuse connection
FAIL
FAIL	net/http	11.607s

greplogs -l -e 'FAIL: TestTransportReuseConnection.*(?:\n .*)* didn'\''t reuse connection' --since=2022-01-01
2022-06-08T19:41:54-bdde41e/freebsd-amd64-race

See previously #22212.

Perhaps a good first step would be to modify the test to use net/http/httptrace to dump more information about what's going on with the connections?

(CC @neild @golang/freebsd)

@bcmills bcmills added help wanted OS-FreeBSD NeedsInvestigation labels Jun 14, 2022
@bcmills bcmills added this to the Backlog milestone Jun 14, 2022
@ayang64
Copy link
Member

@ayang64 ayang64 commented Jun 14, 2022

if noone else does, i'll take a look this afternoon. assigning to myself as a reminder.

@ayang64 ayang64 self-assigned this Jun 14, 2022
@ayang64
Copy link
Member

@ayang64 ayang64 commented Jun 16, 2022

i can't reproduce; will try to set up the same environment: OS Version: FreeBSD 13.0-STABLE FreeBSD 13.0-STABLE #0 stable/13-n248759-3684bb89d52

@bcmills
Copy link
Member Author

@bcmills bcmills commented Jun 16, 2022

@ayang64, given that there is only one of these in the logs, this looks to me to be a very rare failure. I would not expect it to reproduce easily.

(That's why I suggest starting by modifying the test to dump more information — since this failure mode is so rare, ideally we should extract as much information as we can should it occur again.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted NeedsInvestigation OS-FreeBSD
Projects
None yet
Development

No branches or pull requests

2 participants