Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: / keyboard shortcut does not work on Firefox #53380

Open
ian-h-chamberlain opened this issue Jun 14, 2022 · 0 comments
Open

x/pkgsite: / keyboard shortcut does not work on Firefox #53380

ian-h-chamberlain opened this issue Jun 14, 2022 · 0 comments

Comments

@ian-h-chamberlain
Copy link

@ian-h-chamberlain ian-h-chamberlain commented Jun 14, 2022

Seems likely related to #41093.

What is the URL of the page with the issue?

From the above linked issue: https://pkg.go.dev/k8s.io/client-go/kubernetes

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:101.0) Gecko/20100101 Firefox/101.0

Screenshot

Screen Shot 2022-06-14 at 4 53 47 PM

What did you do?

Press / key. I also tried setting accessibility.typeaheadfind.manual to false under the Firefox about:config page, in case it was interfering with the keyboard shortcut implementation. Is there another workaround that might enable the / keyboard shortcut functionality?

What did you expect to see?

Search box highlighted as described in the ? keyboard shortcut modal (quickly "Search packages or symbols")

Other websites (e.g. https://github.com or https://go-review.googlesource.com) seem to support their own search bar (without interference from the Firefox-native "quick find"), but pkg.go.dev does not appear to support this.

What did you see instead?

When accessibility.typeaheadfind.manual is set to true, Firefox opens its "quick find" box:
Screen Shot 2022-06-14 at 4 57 40 PM

When it is set to false, nothing happens when I type the / key.

@gopherbot gopherbot added this to the Unreleased milestone Jun 14, 2022
@ansaba ansaba removed this from the Unreleased milestone Jun 15, 2022
@ansaba ansaba added this to the pkgsite/unplanned milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants