Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/sync/singleflight: add generic version #53427

Open
bradfitz opened this issue Jun 17, 2022 · 4 comments
Open

proposal: x/sync/singleflight: add generic version #53427

bradfitz opened this issue Jun 17, 2022 · 4 comments
Labels
Proposal
Projects
Proposals (old)
Milestone
Proposal

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jun 17, 2022 •
edited

The singleflight package's Group type uses string keys and interface{} values:

https://pkg.go.dev/golang.org/x/sync/singleflight#Group

I've locally forked it to add generics [K comparable, V any] but I'd like to get it upstream instead.

Proposal: add singleflight.TypedGroup[K, V] or singleflight.GenericGroup[K, V] or singleflight.GroupOf[K, V] behind a go1.18 build tag.

Do we have a convention yet on naming new parallel generic types alongside others?

Related: #47657 (for PoolOf, MapOf). (There was also talk of default type parameters so old code could instantiate types and get the old behavior (in this case [string, any]) and new callers could specify types?)
@gopherbot gopherbot added this to the Proposal milestone Jun 17, 2022
bradfitz added a commit to tailscale/tailscale that referenced this issue Jun 17, 2022
@bradfitz
util/singleflight: add fork of singleflight with generics
d48ef78 
Forked from golang.org/x/sync/singleflight at
the x/sync repo's commit 67f06af15bc961c363a7260195bcd53487529a21

Updates golang/go#53427

Change-Id: Iec2b47b7777940017bb9b3db9bd7d93ba4a2e394
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Jun 17, 2022
Merged
bradfitz added a commit to tailscale/tailscale that referenced this issue Jun 17, 2022
@bradfitz
util/singleflight: add fork of singleflight with generics
6351aa1 
Forked from golang.org/x/sync/singleflight at
the x/sync repo's commit 67f06af15bc961c363a7260195bcd53487529a21

Updates golang/go#53427

Change-Id: Iec2b47b7777940017bb9b3db9bd7d93ba4a2e394
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit to tailscale/tailscale that referenced this issue Jun 17, 2022
@bradfitz
util/singleflight: add fork of singleflight with generics
b0bb6b8 
Forked from golang.org/x/sync/singleflight at
the x/sync repo's commit 67f06af15bc961c363a7260195bcd53487529a21

Updates golang/go#53427

Change-Id: Iec2b47b7777940017bb9b3db9bd7d93ba4a2e394
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit to tailscale/tailscale that referenced this issue Jun 17, 2022
@bradfitz
util/singleflight: add fork of singleflight with generics
59ed846 
Forked from golang.org/x/sync/singleflight at
the x/sync repo's commit 67f06af15bc961c363a7260195bcd53487529a21

Updates golang/go#53427

Change-Id: Iec2b47b7777940017bb9b3db9bd7d93ba4a2e394
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Jun 17, 2022
@ianlancetaylor
Copy link
Contributor

I don't think we have a convention yet.

@icholy
Copy link

icholy commented Jun 19, 2022

What about x/sync/v2/singleflight ?

twitchyliquid64 pushed a commit to tailscale/tailscale that referenced this issue Jun 21, 2022
@bradfitz @twitchyliquid64
util/singleflight: add fork of singleflight with generics
98bc6b5 
Forked from golang.org/x/sync/singleflight at
the x/sync repo's commit 67f06af15bc961c363a7260195bcd53487529a21

Updates golang/go#53427

Change-Id: Iec2b47b7777940017bb9b3db9bd7d93ba4a2e394
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@catatsuy
Copy link

I tried it before. Thank you.

refs: #52520

@bradfitz bradfitz mentioned this issue Aug 16, 2022
Open
@gopherbot
Copy link

Change https://go.dev/cl/425187 mentions this issue: all: switch singleflight to use generic

@easyCZ easyCZ mentioned this issue Sep 8, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
Proposals
Status: Incoming
Proposals (old)
Incoming
Milestone
Proposal
Development

No branches or pull requests
5 participants
@bradfitz @icholy @catatsuy @ianlancetaylor @gopherbot