Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: frequent TestSemTableOneAddrCollisionLinear failures since 2022-06-16 #53428

Closed
bcmills opened this issue Jun 17, 2022 · 3 comments
Closed
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Jun 17, 2022

##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
--- FAIL: TestSemTableOneAddrCollisionLinear (0.02s)
    testenv.go:461: [/workdir/tmp/go-build3951896734/b001/runtime.test -test.v -test.run=^TestSemTableOneAddrCollisionLinear$ -test.benchtime=1x] exit status: exit status 1
    testenv.go:490: exit status 1
    testenv.go:491: --- subprocess output ---
        === RUN   TestSemTableOneAddrCollisionLinear
            testenv.go:528: failure to scale linearly: µ_1=201.217µs µ_2=637.562µs p=0.000000
        --- FAIL: TestSemTableOneAddrCollisionLinear (0.02s)
        FAIL
FAIL
FAIL	runtime	596.034s

greplogs -l -e 'FAIL: TestSemTableOneAddrCollisionLinear'
2022-06-17T15:02:55-6c25ba6/linux-386-longtest
2022-06-17T15:02:55-6c25ba6/windows-386-2012
2022-06-17T15:02:55-6c25ba6/windows-arm64-10
2022-06-17T15:02:55-6c25ba6/windows-arm64-11
2022-06-16T21:58:40-9068c68/windows-386-2012
2022-06-16T21:25:35-7bad615/freebsd-arm-paulzhol
2022-06-16T21:25:35-7bad615/windows-arm64-11

(CC @golang/runtime)

@bcmills
Copy link
Member Author

bcmills commented Jun 17, 2022

(Marking as release-blocker because the failure mode is new and frequent, and linux/386 and windows/386 are first-class ports.)

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Jun 17, 2022
@bcmills bcmills added this to the Go1.19 milestone Jun 17, 2022
@mknyszek
Copy link
Contributor

mknyszek commented Jun 17, 2022

I give up. I will make this a benchmark. I no longer believe there's a way to make this test not flaky without running many, many more iterations.

@gopherbot
Copy link

gopherbot commented Jun 17, 2022

Change https://go.dev/cl/412878 mentions this issue: runtime: convert flaky semaphore linearity test into benchmark

jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
Also, add a benchmark for another case that was originally tested.

Also also, remove all the dead code this now creates.

Fixes golang#53428.

Change-Id: Idbba88d3d31d38a8854fd5ed99001e394da27300
Reviewed-on: https://go-review.googlesource.com/c/go/+/412878
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Development

No branches or pull requests

3 participants