Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: "v1.x.y is not a tag" when .gitconfig sets log.decorate to full [1.18 backport] #53588

Closed
bcmills opened this issue Jun 28, 2022 · 2 comments
Closed

cmd/go: "v1.x.y is not a tag" when .gitconfig sets log.decorate to full [1.18 backport] #53588

bcmills opened this issue Jun 28, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18.4

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 28, 2022

@bcmills requested issue #51312 to be considered for backport to the next 1.18 minor release.

This causes erroneous error messages (which may be confusing for users), and the underlying cause is not easy to diagnose.
@bcmills bcmills added this to the Go1.18.4 milestone Jun 28, 2022
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. CherryPickApproved Used during the release process for point releases GoCommand cmd/go labels Jun 28, 2022
@dmitshur dmitshur changed the title cmd/go: "v1.x.y is not a tag" when .gitconfig sets log.decorate to full [1.18 backport] cmd/go: "v1.x.y is not a tag" when .gitconfig sets log.decorate to full [1.18 backport] Jun 28, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/414874 mentions this issue: [release-branch.go1.18] cmd/go: pass --no-decorate when listing git tags for a commit

@gopherbot
Copy link
Contributor

Closed by merging 1872c33 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Jul 6, 2022
@hidu @heschi
[release-branch.go1.18] cmd/go: pass --no-decorate when listing git t…
1872c33 
…ags for a commit

This avoids a parse error when the user's global .gitconfig sets
log.decorate to true.

Updates #51312.
Fixes #53588.

Change-Id: Ic47b0f604c0c3a404ec50d6e09f4e138045ac2f2
Reviewed-on: https://go-review.googlesource.com/c/go/+/387835
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit a30f434)
Reviewed-on: https://go-review.googlesource.com/c/go/+/414874
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 14, 2022
@hidu @bradfitz
[release-branch.go1.18] cmd/go: pass --no-decorate when listing git t…
bcccadb 
…ags for a commit

This avoids a parse error when the user's global .gitconfig sets
log.decorate to true.

Updates golang#51312.
Fixes golang#53588.

Change-Id: Ic47b0f604c0c3a404ec50d6e09f4e138045ac2f2
Reviewed-on: https://go-review.googlesource.com/c/go/+/387835
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit a30f434)
Reviewed-on: https://go-review.googlesource.com/c/go/+/414874
This was referenced Jul 15, 2022
Closed
Closed
@golang golang locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18.4
Development

No branches or pull requests
2 participants
@bcmills @gopherbot