crypto/x509: ParseRevocationList misses entry extensions

[aarongable]

What version of Go are you using (go version)?

go1.19beta1

What did you do?

1. Create an x509.RevocationList with an entry which has extensions (such as a reasonCode)
2. Use x509.CreateRevocationList to sign and serialize the CRL to DER
3. Use x509.ParseRevocationList to parse the CRL

Full demonstration: https://go.dev/play/p/ejqFzRaValY?v=gotip

What did you expect to see?

The exact same in-memory structures should be recreated. In particular, the individual entries should still have all of their extensions.

What did you see instead?

Individual entries are missing their extensions.

[gopherbot]

Change https://go.dev/cl/414877 mentions this issue: crypto/x509: Correctly parse CRL entry extensions

[dr2chase]

@agl @FiloSottile can one or both of you give the CL a look? This code is not my department, though the bug looks completely plausible.

[aarongable]

@rolandshoemaker I believe this also qualifies as a release blocker? I've added a go playground demonstration to the original report.

[rolandshoemaker]

Bah, good catch. We can just treat this as a bug fix for new functionality.