Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: reopen tree for Go 1.20 development #53812

Closed
8 tasks done
joedian opened this issue Jul 12, 2022 · 11 comments
Closed
8 tasks done

all: reopen tree for Go 1.20 development #53812

joedian opened this issue Jul 12, 2022 · 11 comments
Assignees
Labels
early-in-cycle NeedsFix umbrella
Milestone

Comments

@joedian
Copy link

@joedian joedian commented Jul 12, 2022

Current Tree Status: Open for Go 1.20 development

This is a tracking issue for the upcoming task of reopening the tree for Go 1.20 development. (It's created a little early to create room for planning early CLs/branches to land during tree reopening.)

As usual, the tree will initially be open to changes that must land early:

  • https://go.dev/cl/420816 - Bump internal/goversion.Version to 20—this should be the very first CL to be submitted as it marks the start of master branch representing Go 1.20 (rather than Go 1.19). (Example CL.) (@dmitshur)
  • Clean up _p_ / _g_ (@prattmic)
  • Go 1.17 bootstrap (@rsc)
  • Refactor lock ranking (@aclements, optional)
  • Update golang.org/x dependencies for #36905 (@dmitshur)
  • Unified IR merge (@mdempsky)
  • Soft open for bug and stability fixes only, no new features yet (Thursday, Aug 4).
  • Finally, open the tree for all general Go 1.20 changes (Monday, Aug 8).

CC @golang/release.

@joedian joedian added NeedsInvestigation early-in-cycle umbrella labels Jul 12, 2022
@joedian joedian added this to the Go1.20 milestone Jul 12, 2022
@joedian joedian closed this as completed Jul 12, 2022
@joedian joedian reopened this Jul 14, 2022
@prattmic
Copy link
Member

@prattmic prattmic commented Aug 2, 2022

We discussed a few early-in-cycle CLs last week in #43930 (comment):

  • CL stack cleaning up use of _p_ and _g_ in the runtime (@prattmic, high priority, lots of conflict potential)
  • CL stack refactoring runtime lock ranking (@aclements, medium priority, would conflict hard with any lock rank changes)
    • @aclements is unavailable for a few days, so this may need to wait. We can avoid conflicts by ensuring we don't merge any changes to src/runtime/lockrank.go.

A few others that have come up:

These two are mostly about soak time, not conflicts, so I defer to their authors about whether they need to be in the "early in cycle" hold period.

@rsc
Copy link
Contributor

@rsc rsc commented Aug 2, 2022

I'd like to get the "Go 1.17 as bootstrap toolchain" sequence CL 420215 and below landed early-in-cycle, because if there is any builder breakage it will be less disruptive when the tree is quieter. (I am of course doing extensive testing to try to avoid any breakage at all, but you never know.)

@randall77
Copy link
Contributor

@randall77 randall77 commented Aug 2, 2022

The 1-bit heap bitmap CL doesn't need to be early-in-cycle. I'll just get it in when the full tree opens.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 2, 2022

The Go 1.19 release is out, so the tree will be reopening soon (for early in cycle changes first, then generally). I'll work on the first CL to bump goversion.Version.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 2, 2022

Change https://go.dev/cl/420816 mentions this issue: internal/goversion: update Version to 1.20

gopherbot pushed a commit that referenced this issue Aug 2, 2022
This is the start of the Go 1.20 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

For #40705.
For #53812.

Change-Id: Ic8919a61c9b2f3139717434b9c776d1597175448
Reviewed-on: https://go-review.googlesource.com/c/go/+/420816
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@dmitshur dmitshur added NeedsFix and removed NeedsInvestigation labels Aug 2, 2022
@dmitshur dmitshur added this to In Progress in Go Release Team Aug 2, 2022
@mdempsky
Copy link
Member

@mdempsky mdempsky commented Aug 2, 2022

Just to minimize the merge race window (master->dev.unified branch sync, and then dev.unified->master merge), I'd like to merge dev.unified before we open for general development. But I'm happy to do this after any other early-in-cycle CLs have landed. I don't expect this to interfere with any other early CLs.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 3, 2022

We need to update standard-library dependencies (#36905), and it seems like a good idea to fit that in before the general tree opening. I'll take care of it.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 4, 2022

Change https://go.dev/cl/421334 mentions this issue: all: update vendored golang.org/x dependencies for Go 1.20 development

gopherbot pushed a commit that referenced this issue Aug 4, 2022
Go 1.20 development is just beginning. This is a time to update all
golang.org/x/... module versions that contribute packages to the std
and cmd modules in the standard library to latest master versions.

This CL holds back some of the available updates to the x/net module
due to go.dev/issue/54259. It'll be updated in a later separate pass.
x/tools is also held back a bit to avoid pulling in too new of x/net.

For #36905.
For #53812.
Updates #54259.

Change-Id: Iaefe6a343a02cc5ceb85c15125882d64dd372627
Reviewed-on: https://go-review.googlesource.com/c/go/+/421334
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@mdempsky
Copy link
Member

@mdempsky mdempsky commented Aug 4, 2022

dev.unified has been merged back into master: https://go-review.googlesource.com/c/go/+/421374

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 4, 2022

Everything that was planned is in, I've updated the tree status heading to say that bug fixes and stability improvement CLs are okay to land, and the tree can be fully opened on Monday.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 8, 2022

We're ready to complete the tree reopening. Updated the tree status heading to "Open for Go 1.20 development". Happy development!

@dmitshur dmitshur closed this as completed Aug 8, 2022
Go Release Team automation moved this from In Progress to Done Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-in-cycle NeedsFix umbrella
Projects
Development

No branches or pull requests

7 participants