Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/gccgo_link_c failures on illumos/amd64 and aix/ppc64 #53815

Closed
mknyszek opened this issue Jul 12, 2022 · 3 comments
Closed

cmd/go: TestScript/gccgo_link_c failures on illumos/amd64 and aix/ppc64 #53815

mknyszek opened this issue Jul 12, 2022 · 3 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.19

Comments

@mknyszek
Copy link
Contributor

The immediate culprit appears to be https://go.dev/cl/416134.

CC @bcmills @rsc
@mknyszek mknyszek added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Jul 12, 2022
@mknyszek mknyszek added this to the Go1.19 milestone Jul 12, 2022
@mknyszek
Copy link
Contributor Author

Example failures:

https://build.golang.org/log/a368c7af5e59ff8dbf7ad719542fa970acac7e2a
https://build.golang.org/log/17e8cff16241ef66df2595817b861b7fadba309a

@bcmills bcmills self-assigned this Jul 12, 2022
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 12, 2022
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 12, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/417094 mentions this issue: cmd/go: avoid indexing GOROOT packages when the compiler is 'gccgo'

@bcmills
Copy link
Contributor

bcmills commented Jul 12, 2022

Already had a fix pending; added the issue# to it.

@ianlancetaylor ianlancetaylor mentioned this issue Jul 19, 2022
Closed
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@jproberts
cmd/go: avoid indexing GOROOT packages when the compiler is 'gccgo'
62da8d2 
The gccgo compiler does not load standard-library packages from
GOROOT/src, so we cannot load those packages from the GOROOT/src
index when using that compiler.

This fixes TestScript/gccgo_link_c (and perhaps other gccgo tests)
when a 'gccgo' executable is present. Unfortunately, only a few
builders caught the broken test because 'gccgo' is not installed
on most Go project builders (see golang#35786).

For golang#53577.
Fixes golang#53815.

Change-Id: I11a5cf6dbf4ac9893c4d02bd6ab7ef60f67b1e87
Reviewed-on: https://go-review.googlesource.com/c/go/+/417094
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot