Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/buildlet: Reverse Dial Fails in Local devMode #53836

Open
hydernaqvi opened this issue Jul 13, 2022 · 3 comments
Open

x/build/cmd/buildlet: Reverse Dial Fails in Local devMode #53836

hydernaqvi opened this issue Jul 13, 2022 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@hydernaqvi
Copy link

What version of Go are you using (go version)?

$ go version
go1.19

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env


linux/amd64

What did you do?

Followed instructions at https://github.com/golang/build/tree/master/cmd/coordinator

  1. ran go run . -mode=dev -listen-http=localhost:8119
  2. followed by go run golang.org/x/build/cmd/buildlet -halt=false -reverse-type=host-linux-amd64-localdev

What did you expect to see?

Messages confirming reverse mode connection between coordinator and buildlet such as:

Registering reverse mode with coordinator...
Connected to coordinator; reverse dialing active

What did you see instead?

Error dialing coordinator: failed to handshake with coordinator: tls: first record does not look like a TLS handshake

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 13, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jul 13, 2022
@mknyszek mknyszek changed the title x/build/cmd/buildlet Reverse Dial Fails in Local devMode x/build/cmd/buildlet: Reverse Dial Fails in Local devMode Jul 13, 2022
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 13, 2022
@mknyszek
Copy link
Contributor

CC @golang/release

@dmitshur
Copy link
Contributor

Thanks for reporting. We can choose to improve coordinator's local dev mode if that's a good path to implementing and testing some change, and I think @prattmic helped make this work better most recently, but in general local development mode of coordinator is best effort and doesn't make any guarantees.

@prattmic
Copy link
Member

https://go.dev/cl/354309 and https://go.dev/cl/354310 are what I was using to get local reverse buildlets working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants