Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: create runtime_realgcount func to reduce one time stw when fetch goroutine profile #54014

Open
Jun10ng opened this issue Jul 23, 2022 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@Jun10ng
Copy link
Contributor

Jun10ng commented Jul 23, 2022

Using goroutineProfileWithLabelsConcurrent to fetch the number of goroutines leads to STW,

Maybe we can directly call gcount() + fing to avoid STW on pre-profile phase.

@rhysh If I were wrong, please correct me, thanks.

@gopherbot gopherbot added this to the Proposal milestone Jul 23, 2022
@seankhliao seankhliao changed the title proposal:runtime:create runtime_realgcount func to reduce one time stw when fetch goroutine profile proposal: runtime:create runtime_realgcount func to reduce one time stw when fetch goroutine profile Jul 24, 2022
@ianlancetaylor
Copy link
Contributor

There is no API change here, so taking this out of the proposal process.

@ianlancetaylor ianlancetaylor changed the title proposal: runtime:create runtime_realgcount func to reduce one time stw when fetch goroutine profile runtime: create runtime_realgcount func to reduce one time stw when fetch goroutine profile Jul 24, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 24, 2022
@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Proposal compiler/runtime Issues related to the Go compiler and/or runtime. labels Jul 24, 2022
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Backlog Jul 24, 2022
@gopherbot
Copy link

Change https://go.dev/cl/464349 mentions this issue: runtime: reduce one STW when obtaining goroutine configuration file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants