Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: create runtime_realgcount func to reduce one time stw when fetch goroutine profile #54014

Open
Jun10ng opened this issue Jul 23, 2022 · 1 comment
Open

runtime: create runtime_realgcount func to reduce one time stw when fetch goroutine profile #54014

Jun10ng opened this issue Jul 23, 2022 · 1 comment
Labels
NeedsInvestigation
Milestone
Backlog

Comments

@Jun10ng
Copy link
Contributor

Jun10ng commented Jul 23, 2022

Using goroutineProfileWithLabelsConcurrent to fetch the number of goroutines leads to STW,

Maybe we can directly call gcount() + fing to avoid STW on pre-profile phase.

@rhysh If I were wrong, please correct me, thanks.
@gopherbot gopherbot added this to the Proposal milestone Jul 23, 2022
@Jun10ng Jun10ng mentioned this issue Jul 23, 2022
Open
@seankhliao seankhliao changed the title proposal:runtime:create runtime_realgcount func to reduce one time stw when fetch goroutine profile proposal: runtime:create runtime_realgcount func to reduce one time stw when fetch goroutine profile Jul 24, 2022
@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Jul 24, 2022

There is no API change here, so taking this out of the proposal process.

@ianlancetaylor ianlancetaylor changed the title proposal: runtime:create runtime_realgcount func to reduce one time stw when fetch goroutine profile runtime: create runtime_realgcount func to reduce one time stw when fetch goroutine profile Jul 24, 2022
@gopherbot gopherbot added the compiler/runtime label Jul 24, 2022
@ianlancetaylor ianlancetaylor added NeedsInvestigation and removed Proposal compiler/runtime labels Jul 24, 2022
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Backlog Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @Jun10ng