Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: checkEnabled causes some debug lines tests to fail #54029

Open
randall77 opened this issue Jul 24, 2022 · 1 comment
Open

cmd/compile: checkEnabled causes some debug lines tests to fail #54029

randall77 opened this issue Jul 24, 2022 · 1 comment
Assignees
Labels
compiler/runtime NeedsInvestigation
Milestone

Comments

@randall77
Copy link
Contributor

randall77 commented Jul 24, 2022

If you set cmd/compile/internal/ssa/compile.go:checkEnabled to true and run all.bash, some tests fail.

cmd/compile/internal/ssa/debug_lines_test.go
  TestDebugLinesSayHi
  TestDebugLinesPushback
  TestDebugLinesConvert
cmd/compile/internal/ssa/stmtlines_test.go
  TestStmtLines

I suspect this is the randomization done in cmd/compile/internal/ssa/compile.go when checkEnabled is set.

There is a secondary question here, which is why these tests don't already fail on the ssacheck builder. Maybe the GO_GCFLAGS setting doesn't make it through to the subprocess those tests use?

@dr2chase

@gopherbot gopherbot added the compiler/runtime label Jul 24, 2022
@cherrymui cherrymui added the NeedsInvestigation label Jul 25, 2022
@cherrymui cherrymui added this to the Backlog milestone Jul 25, 2022
@cherrymui
Copy link
Member

cherrymui commented Jul 25, 2022

There is a secondary question here, which is why these tests don't already fail on the ssacheck builder. Maybe the GO_GCFLAGS setting doesn't make it through to the subprocess those tests use?

Yeah, it looks like it doesn't pass the flags to subprocesses in those tests.

@dr2chase dr2chase self-assigned this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime NeedsInvestigation
Projects
Status: Todo
Development

No branches or pull requests

4 participants