Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: ICE on embedded method expression with receiver parameter of derived type #54058

Closed
mdempsky opened this issue Jul 25, 2022 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mdempsky
Copy link
Contributor

This program is valid, but ICEs with the nounified frontend: https://go.dev/play/p/54ohNsbev55

It appears to be a bad interaction between method expressions, receiver parameters of derived type, and method embedding.

It currently works with GOEXPERIMENT=unified. Marking for Go 1.20, because I expect enabling unified IR by default is how we'll fix this issue.

/cc @golang/compiler

@mdempsky mdempsky added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 25, 2022
@mdempsky mdempsky added this to the Go1.20 milestone Jul 25, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 25, 2022
@cuonglm
Copy link
Member

cuonglm commented Sep 5, 2022

Unified IR is enabled now, this is fixed at tip.

Should we close this one?

@mdempsky @randall77

@mdempsky
Copy link
Contributor Author

mdempsky commented Sep 5, 2022

Yeah, this never worked, so no need for backports. There's a regress test for this in typeparam/mdempsky/20.go too.

@mdempsky mdempsky closed this as completed Sep 5, 2022
@golang golang locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants