Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: golang.org redirects /pkg/foo/ to another redirect #54081

Open
bradfitz opened this issue Jul 27, 2022 · 2 comments
Open

x/pkgsite: golang.org redirects /pkg/foo/ to another redirect #54081

bradfitz opened this issue Jul 27, 2022 · 2 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jul 27, 2022

The golang.org /pkg/ redirect pages redirect to another redirect:

bradfitz@book1pro ~ % curl -I https://golang.org/pkg/crypto/tls/
HTTP/2 301 
content-type: text/html; charset=utf-8
location: https://go.dev/pkg/crypto/tls/
date: Wed, 27 Jul 2022 02:23:28 GMT
server: Google Frontend

But that location (https://go.dev/pkg/crypto/tls/) serves another redirect:

bradfitz@book1pro ~ % curl -I https://go.dev/pkg/crypto/tls/
HTTP/2 307 
content-type: text/html; charset=utf-8
location: https://pkg.go.dev/crypto/tls
date: Wed, 27 Jul 2022 02:24:40 GMT
server: Google Frontend

Just have golang.org redirect to the version without the trailing slash instead?

@gopherbot gopherbot added this to the Unreleased milestone Jul 27, 2022
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 27, 2022

Change https://go.dev/cl/419634 mentions this issue: doc/go1.19: fix a few links that were missing trailing slashes

@hyangah hyangah modified the milestones: Unreleased, pkgsite/unplanned Jul 28, 2022
gopherbot pushed a commit that referenced this issue Aug 1, 2022
They were part of a chain of three redirects. Now it's only two,
but that's #54081.

Change-Id: Ibfe6a17a372df61df40124892951b48577e4ced9
Reviewed-on: https://go-review.googlesource.com/c/go/+/419634
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants