Repository navigation
testing: TestMain not working sequentially #54118
Description
Package Structure:
/pkg
x_test.go
/pkg/sub-package
y_test.go
x_test.go
import "testing"
import "github.com/ory/dockertest"
func TestMain(m *testing.M) {
pool, _ := dockertest.NewPool("")
resource, _ := pool.Run("mysql", "5.7", []string{"MYSQL_ROOT_PASSWORD=secret"}) // Create and run container
defer pool.Purge(resource) // Kill container
m.Run()
}
func TestXXX(t *testing.T) {
// Do some tests using mysql container running
}y_test.go
import "testing"
import "github.com/ory/dockertest"
func TestMain(m *testing.M) {
pool, _ := dockertest.NewPool("")
resource, _ := pool.Run("mysql", "5.7", []string{"MYSQL_ROOT_PASSWORD=secret"}) // Create and run container
defer pool.Purge(resource) // Kill container
m.Run()
}
func TestYYY(t *testing.T) {
// Do some tests using mysql container running
}If I run the tests in each directory separately, it works perfectly:
- It creates mysql container.
- It Runs the tests.
- It kills the docker container
- Tests end and test results returned
If however I run go test -v ./... from the parent directory:
The tests error out at pool.Run saying that mysql container already exists.
I believe the correct behaviour should be that TestMain should be run independently and sequentially. Only After outer TestMain returns should the inner packages be tested.
That way the containers are already killed before the inner packages are tested, giving the opportunity for the inner package to create their own container (and cleanup themself)
Activity
[-]testing: TestMain not working properly [/-][+]testing: TestMain not working sequentially [/+]bcmills commentedon Jul 28, 2022
This is working as documented. Per https://pkg.go.dev/cmd/go#hdr-Testing_flags:
You can use the
-pflag to control the number of processes thatgo testruns in parallel (see https://pkg.go.dev/cmd/go#hdr-Compile_packages_and_dependencies), so-p 1would run the tests sequentially.That said, it is almost always preferable to structure the tests such that each invocation of the test binary works with its own (hermetic) resources.