Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/png: wrong error message in png.Encode #5413

Closed
gopherbot opened this issue May 6, 2013 · 3 comments
Closed

image/png: wrong error message in png.Encode #5413

gopherbot opened this issue May 6, 2013 · 3 comments
Assignees

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 6, 2013

by destel.od:

Below is piece of code from png.Encode function

423     mw, mh := int64(m.Bounds().Dx()), int64(m.Bounds().Dy())
424     if mw <= 0 || mh <= 0 || mw >= 1<<32 || mh >= 1<<32 {
425         return FormatError("invalid image size: " + strconv.FormatInt(mw, 10) +
"x" + strconv.FormatInt(mw, 10))
426     }

Error message does not contain image height, but contains image width twice.
@alberts
Copy link
Contributor

@alberts alberts commented May 6, 2013

Comment 1:

Want to send a patch?
http://golang.org/doc/contribute.html#Code_review
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 6, 2013

Comment 2:

https://golang.org/cl/9153045

Labels changed: removed priority-triage.

Owner changed to @bradfitz.

Status changed to Started.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 6, 2013

Comment 4:

This issue was closed by revision 1294f14.

Status changed to Fixed.

@gopherbot gopherbot added the fixed label May 6, 2013
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.