Skip to content

x/tools/gopls: deprecate the "experimentalUseInvalidMetadata" setting #54180

Closed
Closed
x/tools/gopls: deprecate the "experimentalUseInvalidMetadata" setting#54180
Labels
FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.
Milestone
gopls/v0.10.0

Description

@findleyr
findleyr
opened on Aug 1, 2022

Discovered while investigating #54147: with "experimentalUseInvalidMetadata" set, we may diagnose a package with invalid metadata, and not re-diagnose when new metadata arrives. This can lead to diagnostics which are stale until you begin typing again.

We could fix this by re-diagnosing after each metadata load, but more generally we should reconsider whether it is worth landing this feature:

Pros:

  • when the workspace is totally broken, gopls will continue to work

Cons:

  • though gopls will continue to work, it may have inconsistent or confusing state
  • users should generally fix broken workspaces before doing anything else
  • we really don't want users to have to restart gopls, so in all other respects we are trying to avoid places where gopls "remembers history"

Activity

  1. findleyr
    added this to the gopls/later milestone on Aug 1, 2022
  2. gopherbot
    added
    ToolsThis label describes issues relating to any tools in the x/tools repository.
    goplsIssues related to the Go language server, gopls.
    on Aug 1, 2022

  3. gopherbot commented on Aug 3, 2022

    @gopherbot
    gopherbot
    on Aug 3, 2022
    Contributor

    Change https://go.dev/cl/420956 mentions this issue: internal/lsp/cache: invalid packages should not be workspace packages

  4. gopherbot
    added a commit that references this issue on Aug 4, 2022

    internal/lsp/cache: invalid packages should not be workspace packages

    01c9ff0
  5. findleyr
    modified the milestones: gopls/later, gopls/v0.10.0 on Sep 22, 2022

  6. findleyr commented on Sep 22, 2022

    @findleyr
    findleyr
    on Sep 22, 2022
    ContributorAuthor

    CC @adonovan

    Unless anyone objects, I propose that we remove this setting. We should avoid any cases where gopls' state is path-dependent.

  7. findleyr
    changed the title [-]x/tools/gopls: reconsider the experimental feature to use invalid metadata[/-] [+]x/tools/gopls: deprecate the "experimentalUseInvalidMetadata" setting[/+] on Sep 22, 2022

  8. gopherbot commented on Sep 26, 2022

    @gopherbot
    gopherbot
    on Sep 26, 2022
    Contributor

    Change https://go.dev/cl/434640 mentions this issue: gopls: deprecate three experimental features

  9. gopherbot
    closed this as completedin bddb372on Sep 28, 2022

  10. gopherbot commented on Nov 18, 2022

    @gopherbot
    gopherbot
    on Nov 18, 2022
    Contributor

    Change https://go.dev/cl/452057 mentions this issue: gopls/internal/lsp/cache: eliminate obsolete invalidation step

  11. gopherbot
    added a commit that references this issue on Nov 29, 2022

    gopls/internal/lsp/cache: eliminate obsolete invalidation step

    ff22fab
  12. netbsd-srcmastr
    added a commit that references this issue on Jan 7, 2023

    gopls: update to 0.11.0

    9f0827d
  13. netbsd-srcmastr
    added a commit that references this issue on Jan 18, 2023

    gopls: update to 0.11.0

    4e10421
  14. jazanne
    added a commit that references this issue on Jun 16, 2023

    Bump golang.org/x/tools from 0.9.3 to 0.10.0 (#360)

    980e318
  15. aviator-app
    added a commit that references this issue on Jun 16, 2023

    ⬆️ Bump golang.org/x/tools from 0.9.3 to 0.10.0 in /src (#3633)

    e000bf7
  16. mergify
    added 2 commits that reference this issue on Jun 19, 2023

    chore(deps): Bump golang.org/x/tools from 0.9.3 to 0.10.0 in /package…

    dc27a34

    chore(deps): Bump golang.org/x/tools from 0.9.3 to 0.10.0 in /package…

    14b5ed2
  17. sywhang
    added a commit that references this issue on Jun 26, 2023

    build(deps): bump golang.org/x/tools from 0.9.3 to 0.10.0 (#122)

    5654686
  18. bors
    added a commit that references this issue on Jun 28, 2023

    Merge #29

    5003098
  19. sywhang
    added a commit that references this issue on Jun 29, 2023

    chore(deps): bump golang.org/x/tools from 0.9.3 to 0.10.0 in /tools (#…

    1d8477e
  20. pendo324
    added a commit that references this issue on Jun 29, 2023

    build(deps): Bump golang.org/x/tools from 0.9.3 to 0.10.0 (#455)

    e321f1d
  21. golang
    locked and limited conversation to collaborators on Nov 18, 2023
  22. gopherbot
    added
    FrozenDueToAge
    on Nov 18, 2023
  23. zebp
    added a commit that references this issue on Feb 16, 2024

    gopls: deprecate three experimental features

    bddb372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions