Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: enable Duff's device on darwin/arm64 #54189

Closed
erifan opened this issue Aug 2, 2022 · 3 comments
Closed

cmd/compile: enable Duff's device on darwin/arm64 #54189

erifan opened this issue Aug 2, 2022 · 3 comments
Assignees
Labels
arch-arm64 compiler/runtime FeatureRequest NeedsFix OS-Darwin Performance
Milestone

Comments

@erifan
Copy link
Contributor

@erifan erifan commented Aug 2, 2022

This is disabled because Darwin linker does not support BR26 relocation with non-zero addend, see #16724. I wonder if we can find a way to work around this issue, since the performance impact of Duff's device is pretty obvious.

@gopherbot gopherbot added the compiler/runtime label Aug 2, 2022
@dmitshur dmitshur added this to the Backlog milestone Aug 2, 2022
@dmitshur dmitshur added Performance NeedsInvestigation labels Aug 2, 2022
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 2, 2022

CC @golang/compiler.

@cherrymui
Copy link
Member

@cherrymui cherrymui commented Aug 2, 2022

There have been several changes to the Go linker. I'm not sure the BR26 issue is still relevant. We can try to enable it.

If it still matters, we can use the label symbol mechanism, which is what we do on Windows ARM64.

I can give it a try.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 2, 2022

Change https://go.dev/cl/420894 mentions this issue: cmd/compile, cmd/link: enable Duff's device on darwin/arm64

@dmitshur dmitshur added NeedsFix and removed NeedsInvestigation labels Aug 3, 2022
@dmitshur dmitshur modified the milestones: Backlog, Go1.20 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 compiler/runtime FeatureRequest NeedsFix OS-Darwin Performance
Projects
Status: Done
Development

No branches or pull requests

5 participants