Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/pkgdoc: doesn't handle new Go 1.19 sync/atomic types #54200

Closed
dmitshur opened this issue Aug 2, 2022 · 1 comment
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 2, 2022

Go 1.19 adds new types to the sync/atomic package, and x/website's documentation renderer appears to need updates to be able to render it. https://tip.golang.org/pkg/sync/atomic/?m=old currently serves 502 as a result. Can be reproduced locally with:

website $ go1.16.15 run ./cmd/golangorg -goroot=$HOME/gotip
2022/08/02 11:25:51 https://go.dev/pkg/sync/atomic/?m=old
2022/08/02 11:25:51 http: panic serving 127.0.0.1:51876: interface conversion: ast.Expr is *ast.IndexExpr, not *ast.Ident

pkg.go.dev renders it okay, as seen at https://pkg.go.dev/sync/atomic@go1.19rc2.

This is similar to #51686.

CC @rsc, @jamalc.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 2, 2022
@dmitshur dmitshur added this to the Unreleased milestone Aug 2, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/420794 mentions this issue: internal/pkgdoc: fix rendering of generics like atomic.Pointer

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 2, 2022
@golang golang locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants