Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: update Go bootstrap on Corellium builders #54246

Closed
rsc opened this issue Aug 4, 2022 · 8 comments
Closed

x/build: update Go bootstrap on Corellium builders #54246

rsc opened this issue Aug 4, 2022 · 8 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Aug 4, 2022

We are going to require Go 1.17 for building Go 1.20 (see #44505).
On most builders we will have the buildlet download the right toolchain automatically.
The Corellium builders do not seem to be able to download from storage.googleapis.com: I get 403 Forbidden.

The ios builder has a toolchain at d6c4583, between Go 1.17 and Go 1.18, which is fine.
The android builder has Go 1.15.3 and will stop building soon.
Can you please update the android builder to Go 1.17 or later?
If you update it to Go 1.19 it might be a good idea to update the ios builder to match
and to get it onto a tagged release, even though it doesn't strictly need an update.

/cc @steeve and @changkun who are listed as the owners of these builders in x/build/dashboard/builders.go.

@rsc rsc self-assigned this Aug 4, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 4, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 4, 2022
@rsc rsc removed their assignment Aug 4, 2022
@gopherbot
Copy link

Change https://go.dev/cl/420902 mentions this issue: cmd/dist: require Go 1.17 for building Go

gopherbot pushed a commit that referenced this issue Aug 4, 2022
This makes builds using earlier Go bootstrap versions fail pretty clearly:

% GOROOT_BOOTSTRAP=$HOME/sdk/go1.16 ./make.bash
Building Go cmd/dist using /Users/rsc/sdk/go1.16. (go1.16 darwin/amd64)
found packages main (build.go) and building_Go_requires_Go_1_17_or_later (notgo117.go) in /Users/rsc/go/src/cmd/dist
%

All the builders have Go 1.17 or later for bootstrap now except
for the android corellium builders, which still need updating (#54246).
We are accepting breakage on those for now.

Fixes #44505.

Change-Id: I12a67f42f61dba43a331cee0a150194d3e42c044
Reviewed-on: https://go-review.googlesource.com/c/go/+/420902
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 4, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Aug 4, 2022

CC @golang/release.

@thanm
Copy link
Contributor

thanm commented Aug 9, 2022

Friendly ping @steeve and @changkun , it would be nice to get these builders back on line (they have been red for a week or so).

jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
This makes builds using earlier Go bootstrap versions fail pretty clearly:

% GOROOT_BOOTSTRAP=$HOME/sdk/go1.16 ./make.bash
Building Go cmd/dist using /Users/rsc/sdk/go1.16. (go1.16 darwin/amd64)
found packages main (build.go) and building_Go_requires_Go_1_17_or_later (notgo117.go) in /Users/rsc/go/src/cmd/dist
%

All the builders have Go 1.17 or later for bootstrap now except
for the android corellium builders, which still need updating (golang#54246).
We are accepting breakage on those for now.

Fixes golang#44505.

Change-Id: I12a67f42f61dba43a331cee0a150194d3e42c044
Reviewed-on: https://go-review.googlesource.com/c/go/+/420902
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
@changkun
Copy link
Member

I am investigating this.

@changkun changkun self-assigned this Aug 10, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 12, 2022
@dmitshur
Copy link
Contributor

It looks like these builders are now using a Go 1.18.3 bootstrap (up from Go 1.15.3), and passing:

Thanks very much for resolving this.

@gopherbot
Copy link

Change https://go.dev/cl/422996 mentions this issue: env/corellium: update Corellium Android builder setup scripts

@changkun
Copy link
Member

changkun commented Aug 13, 2022

The Android builders are now using Go 1.18.3, as @dmitshur noted above. I reconfigured one iOS builder to use Go 1.19 because this builder was removed by Corellium due to their VM reallocation.

Let me know if it is necessary to have all Android and iOS builders use the same 1.19 version as bootstrap.

@dmitshur
Copy link
Contributor

Let me know if it is necessary to have all Android and iOS builders use the same 1.19 version as bootstrap.

I think it's fine for the Android and iOS builders to use slightly different bootstrap versions, given they're all meeting the hard requirement of being at minimum 1.17+. I wouldn't worry about redoing them to be exactly the same versions. In the future after #54265, it's also fine to stay closer to version specified in the dashboard.GoBootstrap constant.

@golang golang locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants