New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/relui,x/build/cmd/release: convert to gRPC coordinator API #54344
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Projects
Milestone
Comments
heschi
added
Builders
x/build issues (builders, bots, dashboards)
NeedsFix
The path to resolution is known, but the work has not been done.
labels
Aug 8, 2022
Change https://go.dev/cl/422096 mentions this issue: |
Change https://go.dev/cl/422095 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Aug 9, 2022
As a first step to port relui over to the gRPC API, create a gRPC client implementation. This should be suitable for use in the gomote command, but I don't want to conflict with the giant stack in flight. Also add a GRPCClient function to iapclient for convenience. The gomote service was missing working directory information; added it. I also did some refactoring/cleanup. - The Client interface is used internally to the coordinator, and as such it has a lot of internal functions. The set used by remote clients is much more reasonable. Separate it out into a new RemoteClient interface. - AddCloseFn was only used in one place. Delete it. - DestroyVM was completely unused. Delete it. For golang/go#54344. Change-Id: I77344a8c27076e53f565e9af56f8d365ac89b487 Reviewed-on: https://go-review.googlesource.com/c/build/+/422095 Auto-Submit: Heschi Kreinick <heschi@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Heschi Kreinick <heschi@google.com>
Change https://go.dev/cl/422636 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Aug 10, 2022
I assumed that it would do this internally and return an error if we weren't on GCE. Apparently I was wrong. For golang/go#54344. Change-Id: I186c7c5416f34682e41534810aba2f5840e69a1b Reviewed-on: https://go-review.googlesource.com/c/build/+/422636 Reviewed-by: Jenny Rakoczy <jenny@golang.org> Auto-Submit: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Heschi Kreinick <heschi@google.com>
Also need to do cmd/release. |
heschi
changed the title
x/build/cmd/relui: convert to gRPC coordinator API
x/build/cmd/relui,x/build/cmd/release: convert to gRPC coordinator API
Aug 16, 2022
Change https://go.dev/cl/424000 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
The HTTP based API is obsolete. Port relui over.
cc @golang/release
The text was updated successfully, but these errors were encountered: