Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/relui,x/build/cmd/release: convert to gRPC coordinator API #54344

Closed
heschi opened this issue Aug 8, 2022 · 5 comments
Closed

x/build/cmd/relui,x/build/cmd/release: convert to gRPC coordinator API #54344

heschi opened this issue Aug 8, 2022 · 5 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented Aug 8, 2022

The HTTP based API is obsolete. Port relui over.

cc @golang/release

@heschi heschi added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 8, 2022
@heschi heschi added this to the Unreleased milestone Aug 8, 2022
@heschi heschi self-assigned this Aug 8, 2022
@gopherbot
Copy link

Change https://go.dev/cl/422096 mentions this issue: cmd/relui: use gRPC buildlet

@gopherbot
Copy link

Change https://go.dev/cl/422095 mentions this issue: buildlet: create gRPC client

gopherbot pushed a commit to golang/build that referenced this issue Aug 9, 2022
As a first step to port relui over to the gRPC API, create a gRPC client
implementation. This should be suitable for use in the gomote command,
but I don't want to conflict with the giant stack in flight. Also add a
GRPCClient function to iapclient for convenience.

The gomote service was missing working directory information; added it.

I also did some refactoring/cleanup.
- The Client interface is used internally to the coordinator, and as
  such it has a lot of internal functions. The set used by remote
  clients is much more reasonable. Separate it out into a new
  RemoteClient interface.
- AddCloseFn was only used in one place. Delete it.
- DestroyVM was completely unused. Delete it.

For golang/go#54344.

Change-Id: I77344a8c27076e53f565e9af56f8d365ac89b487
Reviewed-on: https://go-review.googlesource.com/c/build/+/422095
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/422636 mentions this issue: internal/iapclient: check OnGCE before reading project ID

gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2022
I assumed that it would do this internally and return an error if we
weren't on GCE. Apparently I was wrong.

For golang/go#54344.

Change-Id: I186c7c5416f34682e41534810aba2f5840e69a1b
Reviewed-on: https://go-review.googlesource.com/c/build/+/422636
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
@joedian joedian added this to Done in Go Release Team Aug 16, 2022
@joedian joedian reopened this Aug 16, 2022
@joedian joedian moved this from Done to In Progress in Go Release Team Aug 16, 2022
@heschi
Copy link
Contributor Author

heschi commented Aug 16, 2022

Also need to do cmd/release.

@heschi heschi changed the title x/build/cmd/relui: convert to gRPC coordinator API x/build/cmd/relui,x/build/cmd/release: convert to gRPC coordinator API Aug 16, 2022
@gopherbot
Copy link

Change https://go.dev/cl/424000 mentions this issue: cmd/release: use gRPC to coordinator

Go Release Team automation moved this from In Progress to Done Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

3 participants