Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add to trybot set based on port-specific files #54375

Open
rsc opened this issue Aug 10, 2022 · 2 comments
Open

x/build: add to trybot set based on port-specific files #54375

rsc opened this issue Aug 10, 2022 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Aug 10, 2022

In #53383, @laboger suggests that, for example, if a CL touches a file that only builds in ppc64le, we could add a ppc64le builder to the trybot set automatically. We should investigate whether this is practical.

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 10, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 10, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Aug 10, 2022

Issue #42661 is related, it's about automatically opting-in to longtest builders when a change is deemed to modify the cmd/go command or its tests.

CC @golang/release.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 10, 2022
@prattmic
Copy link
Member

prattmic commented Aug 12, 2022

I can't find the issue, but we've also discussed running only affected tests. e.g., if I change debug/elf it isn't necessary to run encoding/json tests.

This is a similar vein taken to the logical extreme by applying to GOOS/GOARCH, plus adding tests that are otherwise disabled by default. I like the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants