Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: extractReadmes looks in _ directories #54388

Closed
rsc opened this issue Aug 11, 2022 · 1 comment
Closed

x/pkgsite: extractReadmes looks in _ directories #54388

rsc opened this issue Aug 11, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

rsc commented Aug 11, 2022

I have a chmod 0 directory named _data in my module tree.
Go ignores files and directories starting with . and _, so it's not usually a problem.
But for pkgsite it is:

2022/08/11 00:33:45 Info: FetchDataSource: fetched rsc.io/github@latest in 312.062417ms with error FetchModule("rsc.io/github", "latest"): processModuleContents("rsc.io/github", "v0.0.0"): extractReadmes(ctx, "rsc.io/github", "v0.0.0", r): open /Users/rsc/src/rsc.io/github/old/ghtop/_data: permission denied

extractReadmes should not try to access ignored files or directories.
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 11, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 11, 2022
@cuishuang cuishuang mentioned this issue Aug 11, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/422834 mentions this issue: internal/fetch: fix extractReadmes work on _directories

@golang golang locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

internal/fetch: fix extractReadmes work on _directories
2 participants
@rsc @gopherbot