path/filepath: Glob is case-sensitive on Windows #5441

gopherbot · 2013-05-10T18:19:45Z

What steps will reproduce the problem?

Copy the program at http://play.golang.org/p/9G14FfcKES into a .go file and run in a
directory that has write permissions (it will create the test.txt file).

What is the expected output?

Files found with *.txt: [test.txt]
Files found with *.TXT: [test.txt]

What do you see instead?

Files found with *.txt: [test.txt]
Files found with *.TXT: []

Which compiler are you using (5g, 6g, 8g, gccgo)?
8g

Which operating system are you using?
Windows 8 64-bit

Which version are you using?  (run 'go version')
go version go1.1rc3 windows/386


File paths on Windows are normally case-insensitive, but the filepath.Glob is currently
case-sensitive on Windows. I would expect it to be case-sensitive if the OS has
case-sensitive paths, and be case-insensitive if the OS has case-insensitive paths.

rsc · 2013-05-24T17:12:52Z

Comment 1:

fwiw, case sensitivity is a function of the mounted file system, not the OS.

gopherbot · 2013-05-24T17:28:20Z

Comment 2 by me@conradz.com:

See http://msdn.microsoft.com/en-us/library/ee681827%28v=vs.85%29.aspx for a summary of
the different file systems on Windows, and which are case-sensitive. Also note that NTFS
can be case-sensitive or insentive, depending on the global OS settings. UDF is the only
common file system on Windows that is always case-sensitive. Making Windows
case-insensitive would take care of 99.9% of cases, but there would be a few edge cases.

robpike · 2013-05-28T14:01:56Z

Comment 3:

Labels changed: added priority-later, removed priority-triage.

Status changed to Thinking.

alexbrainman · 2013-05-28T23:43:38Z

Comment 5:

I think Russ's argument does not fly here. Whe have an issue here where Go program
cannot find file that is there. It is irrelevent what file system capabilities are,
since win32 api (we use it to access os services) makes them all look case insensitive.
From http://support.microsoft.com/kb/100625:
"... The difference in behavior noted here applies only when an application needs to
locate an existing file. POSIX takes advantage of the full case sensitive mode, while
MS-DOS, WOW, and Win32 subsystems use the case insensitive mode. ..."
I am yet to see a windows program that assumes case sensitive mode.
Here is cmd.exe to demonstrate:
C:\tmp\aaa>dir
 Volume in drive C has no label.
 Volume Serial Number is F582-OP83
 Directory of C:\tmp\aaa
29/05/2013  09:16 AM    <DIR>          .
29/05/2013  09:16 AM    <DIR>          ..
               0 File(s)              0 bytes
               2 Dir(s)  115,812,872,192 bytes free
C:\tmp\aaa>echo hello > a.txt
C:\tmp\aaa>dir
 Volume in drive C has no label.
 Volume Serial Number is F582-OP83
 Directory of C:\tmp\aaa
29/05/2013  09:16 AM    <DIR>          .
29/05/2013  09:16 AM    <DIR>          ..
29/05/2013  09:16 AM                 8 a.txt
               1 File(s)              8 bytes
               2 Dir(s)  115,812,872,192 bytes free
C:\tmp\aaa>echo hello2 > A.TXT
C:\tmp\aaa>dir
 Volume in drive C has no label.
 Volume Serial Number is F582-OP83
 Directory of C:\tmp\aaa
29/05/2013  09:16 AM    <DIR>          .
29/05/2013  09:16 AM    <DIR>          ..
29/05/2013  09:17 AM                 9 a.txt
               1 File(s)              9 bytes
               2 Dir(s)  115,812,872,192 bytes free
C:\tmp\aaa>dir *.txt
 Volume in drive C has no label.
 Volume Serial Number is F582-OP83
 Directory of C:\tmp\aaa
29/05/2013  09:17 AM                 9 a.txt
               1 File(s)              9 bytes
               0 Dir(s)  115,812,872,192 bytes free
C:\tmp\aaa>dir *.TXT
 Volume in drive C has no label.
 Volume Serial Number is F582-OP83
 Directory of C:\tmp\aaa
29/05/2013  09:17 AM                 9 a.txt
               1 File(s)              9 bytes
               0 Dir(s)  115,812,872,192 bytes free
C:\tmp\aaa>dir A.TXT
 Volume in drive C has no label.
 Volume Serial Number is F582-OP83
 Directory of C:\tmp\aaa
29/05/2013  09:17 AM                 9 a.txt
               1 File(s)              9 bytes
               0 Dir(s)  115,812,872,192 bytes free
C:\tmp\aaa>dir a.txt
 Volume in drive C has no label.
 Volume Serial Number is F582-OP83
 Directory of C:\tmp\aaa
29/05/2013  09:17 AM                 9 a.txt
               1 File(s)              9 bytes
               0 Dir(s)  115,812,872,192 bytes free
C:\tmp\aaa>type a.txt
hello2
C:\tmp\aaa>type A.TXT
hello2
C:\tmp\aaa>type A.txT
hello2
C:\tmp\aaa>del a.txt
C:\tmp\aaa>dir
 Volume in drive C has no label.
 Volume Serial Number is F483-CD2E
 Directory of C:\tmp\aaa
29/05/2013  09:24 AM    <DIR>          .
29/05/2013  09:24 AM    <DIR>          ..
               0 File(s)              0 bytes
               2 Dir(s)  115,812,839,424 bytes free
C:\tmp\aaa>echo hello > A.TXT
C:\tmp\aaa>dir
 Volume in drive C has no label.
 Volume Serial Number is F483-CD2E
 Directory of C:\tmp\aaa
29/05/2013  09:24 AM    <DIR>          .
29/05/2013  09:24 AM    <DIR>          ..
29/05/2013  09:24 AM                 8 A.TXT
               1 File(s)              8 bytes
               2 Dir(s)  115,812,839,424 bytes free
C:\tmp\aaa>
IMO our current implementation behaives differently, and should be changed.
Alex

alexbrainman · 2013-05-29T04:50:55Z

Comment 6:

me@conradz.com,
Can you see if https://golang.org/cl/9666048 fixes your problem, please? Thank
you.
Alex

gopherbot · 2013-05-29T09:28:24Z

Comment 7 by me@conradz.com:

Yes, the above change does work. Globs are case-insensitive on Windows with the change
applied.

alexbrainman · 2013-05-29T23:16:08Z

Comment 8:

me@conradz.com,
Thank you for testing. Leaving for rsc and r to decide what to do.
Alex

alexbrainman · 2013-06-20T23:06:17Z

Comment 9:

r / rsc, can you, please, decide one way or the other, so we can close this. Thank you.
Alex

adg · 2013-06-21T02:53:49Z

Comment 10:

I'm not r/rsc, but I think the proposed change is the right direction.

robpike · 2013-06-21T03:10:02Z

Comment 11:

I put some comments on https://golang.org/cl/9666048/

rsc · 2013-07-30T16:49:20Z

Comment 12:

Labels changed: added go1.2maybe.

rsc · 2013-07-30T22:41:21Z

Comment 13:

Labels changed: added feature.

rsc · 2013-09-09T19:35:38Z

Comment 14:

Too late.

Labels changed: added go1.3maybe, removed go1.2maybe.

rsc · 2013-11-27T20:29:33Z

Comment 15:

Labels changed: removed feature.

rsc · 2013-12-04T01:31:31Z

Comment 16:

Labels changed: added release-none, removed go1.3maybe.

rsc · 2013-12-04T01:51:54Z

Comment 17:

Labels changed: added repo-main.

alexbrainman · 2015-05-18T01:50:19Z

My proposed fix https://codereview.appspot.com/9666048 and all comments are lost now. The URL returns "No issue exists with that id (9666048)". As far as I remember my proposal was rejected and @rsc was going to send his own fix. I am not clear of rejection reason. As far as I recall I was not clear back then either. Perhaps it was to do with not wanting to import "unicode" package here.

Alex

robpike · 2015-05-18T16:33:31Z

Sorry about that. The transition to github was bumpy and lossy.

mwhudson · 2015-05-18T21:16:32Z

You can find at least some of the info by searching for "9666048" on golang-dev and golang-codereviews.

minux · 2015-05-18T21:24:20Z

Yeah, it's still available in mailing list archives. http://grokbase.com/t/gg/golang-dev/136n3jv86z/code-review-9666048-path-filepath-ignore-case-when-matching-on-windows-issue-9666048

alexbrainman · 2015-05-19T00:13:51Z

Thank you for history search pointers. But, more importantly, I think we need to remove "Thinking" label off this issue. We need to decide what to do here. We might decide it is working as intended, then we should document that Glob search is case-sensitive. Or we might decide to change the code.

Alex

phoenix147 · 2018-01-20T19:02:59Z

I just ran into this problem and wanted to ask if there is a decision for this?

rsc · 2018-11-28T18:51:26Z

It seems too late to try to change this. It would require a lot of checking of whether a particular file system is case-sensitive. You'd have to check in every directory where you were evaluating wildcards, and I'm not even sure how to check.

Do other languages attempt to do this? I know Python, Node, etc have globbing libraries.

freb · 2018-12-12T01:20:08Z

In the Python pathlib module, there are only two different flavours used by glob and the other functions: Windows and Posix

Each has their own implementation of casefold, which prepares path strings for comparison. Windows uses lower case, and Posix uses the original case.

It doesn't appear to take file system case sensitivity into account.

gopherbot · 2019-01-05T18:44:55Z

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

neclepsio · 2021-05-21T10:23:56Z

Is there any workaround for this?

gopherbot added Thinking priority-later labels Dec 4, 2013

rsc added this to the Unplanned milestone Apr 10, 2015

rsc removed priority-later labels Apr 10, 2015

hymkor mentioned this issue Apr 22, 2015

*.CSV does not match foo.csv. (Case is not ignored) nyaosorg/nyagos#58

Closed

alexbrainman mentioned this issue May 17, 2015

path/filepath: Glob malfunction under Windows when pattern matching is used #10875

Closed

bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 21, 2018

bradfitz modified the milestones: Unplanned, Go1.11 Jan 21, 2018

bradfitz added the OS-Windows label Jan 21, 2018

gen2brain mentioned this issue Feb 9, 2018

globs supports gen2brain/goiv#2

Closed

andrewkroh mentioned this issue Apr 3, 2018

Different case-sensitive behavior in the prospectors for Windows paths depending on the use of wildcards elastic/beats#6737

Closed

ghost mentioned this issue Jun 7, 2018

Case sensitive FileExists function? #25786

Closed

ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 27, 2018

ianlancetaylor removed the Thinking label Jun 27, 2018

andybons added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 5, 2018

andybons modified the milestones: Go1.12, Go1.13 Dec 5, 2018

gopherbot closed this as completed Jan 5, 2019

dominikh reopened this Jan 5, 2019

andybons removed this from the Go1.13 milestone Jul 8, 2019

ALTree removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 7, 2020

neclepsio mentioned this issue May 24, 2021

path/filepath: Glob fails and hangs on Windows when using character ranges #46338

Open

seankhliao mentioned this issue Dec 9, 2021

path/filepath: Glob is case sensitive on windows #50080

Closed

seankhliao added this to the Unplanned milestone Aug 20, 2022

moloch-- mentioned this issue Nov 30, 2022

File System Commands are Always Case Sensitive BishopFox/sliver#1017

Closed

mpfz0r mentioned this issue Feb 9, 2023

Match collector_binaries_accesslist case insensitive on windows and MacOS Graylog2/collector-sidecar#467

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

path/filepath: Glob is case-sensitive on Windows #5441

path/filepath: Glob is case-sensitive on Windows #5441

gopherbot commented May 10, 2013

rsc commented May 24, 2013

gopherbot commented May 24, 2013

robpike commented May 28, 2013

alexbrainman commented May 28, 2013

alexbrainman commented May 29, 2013

gopherbot commented May 29, 2013

alexbrainman commented May 29, 2013

alexbrainman commented Jun 20, 2013

adg commented Jun 21, 2013

robpike commented Jun 21, 2013

rsc commented Jul 30, 2013

rsc commented Jul 30, 2013

rsc commented Sep 9, 2013

rsc commented Nov 27, 2013

rsc commented Dec 4, 2013

rsc commented Dec 4, 2013

alexbrainman commented May 18, 2015

robpike commented May 18, 2015

mwhudson commented May 18, 2015

minux commented May 18, 2015 via email

alexbrainman commented May 19, 2015

phoenix147 commented Jan 20, 2018

rsc commented Nov 28, 2018

freb commented Dec 12, 2018

gopherbot commented Jan 5, 2019

neclepsio commented May 21, 2021

path/filepath: Glob is case-sensitive on Windows #5441

path/filepath: Glob is case-sensitive on Windows #5441

Comments

gopherbot commented May 10, 2013

rsc commented May 24, 2013

gopherbot commented May 24, 2013

robpike commented May 28, 2013

alexbrainman commented May 28, 2013

alexbrainman commented May 29, 2013

gopherbot commented May 29, 2013

alexbrainman commented May 29, 2013

alexbrainman commented Jun 20, 2013

adg commented Jun 21, 2013

robpike commented Jun 21, 2013

rsc commented Jul 30, 2013

rsc commented Jul 30, 2013

rsc commented Sep 9, 2013

rsc commented Nov 27, 2013

rsc commented Dec 4, 2013

rsc commented Dec 4, 2013

alexbrainman commented May 18, 2015

robpike commented May 18, 2015

mwhudson commented May 18, 2015

minux commented May 18, 2015 via email

alexbrainman commented May 19, 2015

phoenix147 commented Jan 20, 2018

rsc commented Nov 28, 2018

freb commented Dec 12, 2018

gopherbot commented Jan 5, 2019

neclepsio commented May 21, 2021