You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am able to re-unify "internal/singleflight" and "golang.org/x/sync/singleflight" APIs, the last missing piece is Group.ForgetUnshared, which is implemented in the former, but not the later.
I propose we add this method to golang.org/x/sync/singleflight.Group:
// ForgetUnshared tells the Group to forget about a key if it is not
// shared with any other goroutines. Future calls to Do for a forgotten key
// will call the function rather than waiting for an earlier call to complete.
// Returns whether the key was forgotten or unknown--that is, whether no
// other goroutines are waiting for the result.
func (g *Group) ForgetUnshared(key string) bool
ianlancetaylor
changed the title
proposal: golang.org/x/sync/singleflight: Add Group.ForgetUnshared
proposal: x/sync/singleflight: Add Group.ForgetUnshared
Aug 14, 2022
After #44505, it's now easier to fix #31697.
I am able to re-unify "internal/singleflight" and "golang.org/x/sync/singleflight" APIs, the last missing piece is
Group.ForgetUnshared
, which is implemented in the former, but not the later.I propose we add this method to
golang.org/x/sync/singleflight.Group
:to unblock #31697.
The text was updated successfully, but these errors were encountered: