Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: remove test dependency on gopkg.in service #54503

Open
bcmills opened this issue Aug 17, 2022 · 4 comments
Open

cmd/go: remove test dependency on gopkg.in service #54503

bcmills opened this issue Aug 17, 2022 · 4 comments
Labels
GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Aug 17, 2022

The gopkg.in service has occasional downtime (most recently niemeyer/gopkg#78).
Some of the cmd/go tests of gopkg.in modules are isolated from outages by the Go module proxy, but unfortunately others fail when the service is down.

As far as I can tell, the go-import metadata served by gopkg.in is mostly static. (It may add some value in serving up-to-date go-source metadata, but cmd/go does not depend on that metadata.) Since we're going to have a test-local HTTPS server anyway for #27494, perhaps we can migrate the gopkg.in tests to use that server with static go-import metadata instead.

@heschi
Copy link
Contributor

heschi commented Aug 17, 2022

In this particular case I think GitHub was down...

@gopherbot
Copy link

gopherbot commented Aug 17, 2022

Change https://go.dev/cl/424594 mentions this issue: cmd/go: disable test cases that depend on gopkg.in

@bcmills
Copy link
Member Author

bcmills commented Aug 17, 2022

I've been having trouble with -longtest TryBots all day, and it's only the gopkg.in tests that are flaking.

(It may be that the underlying problem is on GitHub's side, but it doesn't seem to affect the GitHub-only tests. And long-term we may want to reduce our dependence on those too.)

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Aug 17, 2022
gopherbot pushed a commit that referenced this issue Aug 17, 2022
Updates #54503.

Change-Id: Ie13d028b09260d2d316c343b3ea812bb9cce4e6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/424594
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
@joedian joedian added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 18, 2022
@seankhliao seankhliao added this to the Go1.20 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

6 participants