Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: windows/amd64 invalid binary when allocating array near symbol size limit #54564

Open
argusdusty opened this issue Aug 20, 2022 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone

Comments

@argusdusty
Copy link

argusdusty commented Aug 20, 2022

What version of Go are you using (go version)?

$ go version
go version go1.19 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Argusdusty\AppData\Local\go-build
set GOENV=C:\Users\Argusdusty\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=O:\Code\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=O:\Code
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.19
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=O:\Code\src\foo\go.mod
set GOWORK=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\ARGUSD~1\AppData\Local\Temp\go-build1331241143=/tmp/go-build -gno-record-gcc-switches

What did you do?

https://go.dev/play/p/x7RM0aBCBYz:

package main

var A [2000000000]byte

func main() {
	A[0] = 0
}

Create this locally as foo.go, Then go run foo.go

What did you expect to see?

Successful execution

What did you see instead?

$ go run foo.go
fork/exec C:\Users\ARGUSD~1\AppData\Local\Temp\go-build1278580373\b001\exe\foo.exe: %1 is not a valid Win32 application.

Binary search testing different numbers of bytes shows the code works up to 1995296640 bytes, produces the above error for 1995296641-2000000000, and produces symbol too large errors above that.

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 20, 2022
@seankhliao seankhliao added this to the Unplanned milestone Aug 20, 2022
@dr2chase
Copy link
Contributor

dr2chase commented Aug 23, 2022

@alexbrainman not expecting you to fix this necessarily, but are you familiar with what sort of error or implementation restriction might be causing this?

@alexbrainman
Copy link
Member

alexbrainman commented Aug 28, 2022

fork/exec C:\Users\ARGUSD~1\AppData\Local\Temp\go-build1278580373\b001\exe\foo.exe: %1 is not a valid Win32 application.

Windows loader tries to run Go executable and fails with ERROR_BAD_EXE_FORMAT error message.

I suspect the problem is that pe file optional header SizeOfImage is larger that 2 GB. See

PE32+ images allow for a 64-bit address space while limiting the image size to 2 gigabytes.

from https://docs.microsoft.com/en-us/windows/win32/debug/pe-format

Also

https://stackoverflow.com/questions/6976693/what-is-the-maximum-size-of-a-pe-file-on-64-bit-windows

You can use this online tool

https://speedtesting.herokuapp.com/peviewer/

to check particular exe.

produces symbol too large errors

This is unrelated message from Go linker:

a@spot:~/go/src$ git grep -ne "symbol too large"
...
cmd/link/internal/ld/data.go:2076:                      ctxt.Errorf(s, "symbol too large (%d bytes)", ss)
a@spot:~/go/src$

that rejects symbols larger than 2GB.

I hope it helps. But I doubt.

Alex

@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Development

No branches or pull requests

6 participants