Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestArenaCollision failure with "allocation … in reserved region" #54597

Closed
bcmills opened this issue Aug 22, 2022 · 2 comments
Closed
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 22, 2022

#!watchflakes
post <- pkg == "runtime" && test == "TestArenaCollision" && `allocation .* in reserved region`

greplogs -l -e 'FAIL: TestArenaCollision .*(?:\n\s.*)* allocation .* in reserved region' --since=2022-01-01
2022-08-17T17:47:37-bc80579/linux-amd64-fedora

(attn @golang/runtime; this may be closely related to #49415.)

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 22, 2022
@mknyszek mknyszek added this to the Go1.20 milestone Aug 24, 2022
@mknyszek mknyszek self-assigned this Aug 24, 2022
@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestArenaCollision" && `allocation .* in reserved region`
2022-10-24 21:26 linux-386-buster go@3617514d runtime.TestArenaCollision (log)
--- FAIL: TestArenaCollision (0.06s)
    malloc_test.go:284: === RUN   TestArenaCollision
            malloc_test.go:310: allocation 0xe9408000 in reserved region [0xe9400000, 0xe9800000)
        --- FAIL: TestArenaCollision (0.05s)
        FAIL

        (exit status exit status 1)

watchflakes

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/446877 mentions this issue: runtime: skip TestArenaCollision on failed reservation

romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
If TestArenaCollision cannot reserve the address range it expects to
reserve, it currently fails somewhat mysteriously. Detect this case
and skip the test. This could lead to test rot if we wind up always
skipping this test, but it's not clear that there's a better answer.
If the test does fail, we now also log what it thinks it reserved so
the failure message is more useful in debugging any issues.

Fixes golang#49415
Fixes golang#54597

Change-Id: I05cf27258c1c0a7a3ac8d147f36bf8890820d59b
Reviewed-on: https://go-review.googlesource.com/c/go/+/446877
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@golang golang locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
Archived in project
Development

No branches or pull requests

3 participants