net/http: skip TestDirJoin on Windows, even if /etc/hosts exists

[shivakumargn]

Multiple test failures occur while building Go sources on Win7/64bit.

go test output for net/http package is attached.

Attachments:

1. out.txt (9830 bytes)

[alexbrainman]

Comment 1:

TestDirJoin is meant to be skipped on windows:
C:\>go test -v -run=DirJoin net/http
=== RUN TestDirJoin
--- SKIP: TestDirJoin (0.00 seconds)
        fs_test.go:264: skipping test; no /etc/hosts file
PASS
ok      net/http        0.734s
C:\>
How did you manage to run this test?
Alex

Status changed to WaitingForReply.

[shivakumargn]

Comment 2:

I have D:\etc\hosts present in my filesystem.
The test skip rule depends on os.Stat("/etc/hosts") returning an error.
On windows os.Stat return is based on GetFileAttributesEx() which seems to use drive of
working directory as the "/"
os.Stat() may need to be fixed for windows so that path starting with "/" is not
considered valid.
Will prepare a patch.

[alexbrainman]

Comment 3:

Ahhaaa!!! Good detective work. Please, send a fix.
As to your other failures, I didn't get chance to look at then yet. But here is
https://golang.org/issue/5263 something similar. Perhaps it is just
a matter of you debugging to see why it breaks.
Alex

[rsc]

Comment 4:

Labels changed: added priority-later, go1.2, removed priority-triage.

Status changed to Accepted.

[shivakumargn]

Comment 5:

CL submitted https://golang.org/cl/12123043

[bradfitz]

Comment 6:

This issue was closed by revision 3abaf5c.

Status changed to Fixed.