Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: high rate of test timeouts on 2022-08-08 #54606

Closed
bcmills opened this issue Aug 22, 2022 · 3 comments
Closed

crypto/tls: high rate of test timeouts on 2022-08-08 #54606

bcmills opened this issue Aug 22, 2022 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Aug 22, 2022

greplogs -l -e 'goroutine \d+ \[IO wait, .*\]:\n(?:.+\n\t.+\n)*crypto/tls\.TestServerHandshakeContextCancellation'
2022-08-08T15:33:45-0581d69/freebsd-amd64-13_0
2022-08-08T15:33:45-0581d69/openbsd-386-68
2022-08-08T15:22:02-dd59088/dragonfly-amd64-622
2022-08-08T14:12:21-e761556/windows-amd64-2012
2022-08-08T14:12:03-fe406c8/linux-386
2022-08-08T14:12:03-fe406c8/linux-amd64-race
2022-08-08T14:10:37-5405df0/freebsd-386-12_3
2022-08-08T14:10:19-964f0c7/windows-amd64-2012

Since these failures were all clustered around a few CLs on 2022-08-08, it's not clear to me whether this was a regression that has been fixed or a flaky test that happened to correlate in time due to some external factor.

@FiloSottile, @golang/security: are you aware of any changes that would explain this apparent regression and/or its fix?

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 22, 2022
@bcmills bcmills added this to the Go1.20 milestone Aug 22, 2022
@bcmills bcmills changed the title crypto/tls: timeouts in TestServerHandshakeContextCancellation on 2022-08-08 crypto/tls: high rate of test timeouts on 2022-08-08 Aug 22, 2022
@cuonglm
Copy link
Member

cuonglm commented Aug 22, 2022

One of my CL causes higher failed rate was reverted https://go-review.googlesource.com/c/go/+/422035

@bcmills
Copy link
Member Author

bcmills commented Aug 22, 2022

Nice, thank you for the reference! That does seem to explain these failures.

I think I spotted the bug, and left a comment about it on https://go.dev/cl/405674. If you'd like to retry that change, you're welcome to mail to to me — I can also suggest some unit-tests that might expose that race. 🙂

@bcmills bcmills closed this as completed Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants