Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go test -race does not set implicit race build tag [1.19 backport] #54660

Closed
gopherbot opened this issue Aug 24, 2022 · 3 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #54468 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19 and 1.18. This is a regression from prior releases that can cause build failures.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 24, 2022
@gopherbot gopherbot added this to the Go1.19.1 milestone Aug 24, 2022
@bcmills bcmills added the GoCommand cmd/go label Aug 24, 2022
@bcmills bcmills changed the title cmd/go: go test -race report cannot find package when test has "//go:build race" [1.19 backport] cmd/go: go test -race does not set implicit race build tag [1.19 backport] Aug 24, 2022
@bcmills
Copy link
Member

bcmills commented Aug 25, 2022

Approved: this is a regression from Go 1.17 that causes previously-valid tests to fail, and the fix is small.

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Aug 25, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 25, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/426434 mentions this issue: [release-branch.go1.19] cmd/go/internal/imports: include ToolTags in the Tags map

@gopherbot
Copy link
Author

Closed by merging 4da9d6a to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Aug 29, 2022
…the Tags map

This fixes a regression introduced when the "race" mode tag was moved to
the ToolTags field in CL 358539.

Fixes #54660
Updates #54468

Change-Id: I107771948a4fe9d743cc13d1c15f324212b08e03
GitHub-Last-Rev: d211e35
GitHub-Pull-Request: #54618
Reviewed-on: https://go-review.googlesource.com/c/go/+/425154
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 6ba2674)
Reviewed-on: https://go-review.googlesource.com/c/go/+/426434
Reviewed-by: Heschi Kreinick <heschi@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Sep 8, 2022
…the Tags map

This fixes a regression introduced when the "race" mode tag was moved to
the ToolTags field in CL 358539.

Fixes golang#54660
Updates golang#54468

Change-Id: I107771948a4fe9d743cc13d1c15f324212b08e03
GitHub-Last-Rev: d211e35
GitHub-Pull-Request: golang#54618
Reviewed-on: https://go-review.googlesource.com/c/go/+/425154
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 6ba2674)
Reviewed-on: https://go-review.googlesource.com/c/go/+/426434
Reviewed-by: Heschi Kreinick <heschi@google.com>
@golang golang locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Development

No branches or pull requests

2 participants