Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: git fetch errors dropped when producing pseudo-versions for commits [1.19 backport] #54734

Closed
gopherbot opened this issue Aug 29, 2022 · 2 comments

Comments

@gopherbot
Copy link

@bcmills requested issue #53935 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.18 and 1.19. This can cause the go command to resolve unexpected pseudo-versions for commits and branches, and the fix is very small.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 29, 2022
@gopherbot gopherbot added this to the Go1.19.1 milestone Aug 29, 2022
@bcmills bcmills changed the title cmd/go: git test failures with v0.0.0- pseudo-versions [1.19 backport] cmd/go: git fetch errors dropped when producing pseudo-versions for commits [1.19 backport] Aug 29, 2022
@bcmills bcmills added GoCommand cmd/go modules CherryPickApproved Used during the release process for point releases labels Aug 29, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 29, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/426494 mentions this issue: [release-branch.go1.19] cmd/go/internal/modfetch: report error on failing to derive pseudo version from recent tag

@bcmills bcmills added the CherryPickCandidate Used during the release process for point releases label Aug 29, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 29, 2022
@bcmills
Copy link
Member

bcmills commented Aug 29, 2022

This turned out not to be so trivial after all (broke the non-git VCS implementations). Let's just not backport it.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2022
@dmitshur dmitshur removed the CherryPickApproved Used during the release process for point releases label Dec 29, 2022
@golang golang locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants