Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: cannot find package when importing dependencies with the unix build constraint [1.19 backport] #54736

Closed
gopherbot opened this issue Aug 29, 2022 · 2 comments
Closed

cmd/go: cannot find package when importing dependencies with the unix build constraint [1.19 backport] #54736

gopherbot opened this issue Aug 29, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.19.1

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #54712 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19. This is a subtle bug in a feature introduced in Go 1.19, and the fix in Go 1.20 will mask spurious build failures that users on Go 1.19 will run into.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 29, 2022
@gopherbot gopherbot mentioned this issue Aug 29, 2022
Closed
@gopherbot gopherbot added this to the Go1.19.1 milestone Aug 29, 2022
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Aug 29, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 29, 2022
@bcmills bcmills added the GoCommand cmd/go label Aug 29, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/426814 mentions this issue: [release-branch.go1.19] cmd/go/internal/imports: recognize "unix" build tag

@gopherbot
Copy link
Contributor Author

Closed by merging 4580d6d to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Aug 30, 2022
@ZekeLu @heschi
[release-branch.go1.19] cmd/go/internal/imports: recognize "unix" bui…
4580d6d 
…ld tag

For #20322
For #51572
Updates #54712
Fixes #54736

Change-Id: I22fcfa820e83323bfdf1a40deee7286240f02b3e
GitHub-Last-Rev: cd2c653
GitHub-Pull-Request: #54716
Reviewed-on: https://go-review.googlesource.com/c/go/+/426296
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 3c6a5cd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/426814
Run-TryBot: Bryan Mills <bcmills@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Sep 8, 2022
@ZekeLu @bradfitz
[release-branch.go1.19] cmd/go/internal/imports: recognize "unix" bui…
9c9f8ee 
…ld tag

For golang#20322
For golang#51572
Updates golang#54712
Fixes golang#54736

Change-Id: I22fcfa820e83323bfdf1a40deee7286240f02b3e
GitHub-Last-Rev: cd2c653
GitHub-Pull-Request: golang#54716
Reviewed-on: https://go-review.googlesource.com/c/go/+/426296
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 3c6a5cd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/426814
Run-TryBot: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.19.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot