Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/jsonrpc2_v2: TestServe failures #54750

Closed
heschi opened this issue Aug 29, 2022 · 5 comments
Closed

x/tools/internal/jsonrpc2_v2: TestServe failures #54750

heschi opened this issue Aug 29, 2022 · 5 comments
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented Aug 29, 2022

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2_v2" && test == "TestServe"

2022-08-29T14:52:44-717a671-a1c9783/openbsd-386-68
2022-08-29T01:35:52-717a671-7f92cce/openbsd-386-68
2022-08-25T11:40:57-db6a62c-d4ff25a/openbsd-386-68

--- FAIL: TestServe (1.96s)
    --- FAIL: TestServe/tcp (0.25s)
        serve_test.go:137: close tcp 127.0.0.1:42277: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $233
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
        /tmp/workdir/go/src/net/net.go:183:                                           (*conn).Read
        /tmp/workdir/go/src/bufio/bufio.go:106:                                       (*Reader).fill
        /tmp/workdir/go/src/bufio/bufio.go:372:                                       (*Reader).ReadSlice
        /tmp/workdir/go/src/bufio/bufio.go:447:                                       (*Reader).collectFragments
        /tmp/workdir/go/src/bufio/bufio.go:495:                                       (*Reader).ReadString
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/frame.go:120: (*headerReader).Read
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:295:  (*Connection).readIncoming
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:112:  newConnection
        
        [IO wait]: $109
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
        /tmp/workdir/go/src/net/net.go:183:                                           (*conn).Read
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:204: (*idleCloser).Read
        /tmp/workdir/go/src/bufio/bufio.go:106:                                       (*Reader).fill
        /tmp/workdir/go/src/bufio/bufio.go:372:                                       (*Reader).ReadSlice
        /tmp/workdir/go/src/bufio/bufio.go:447:                                       (*Reader).collectFragments
        /tmp/workdir/go/src/bufio/bufio.go:495:                                       (*Reader).ReadString
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/frame.go:120: (*headerReader).Read
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:295:  (*Connection).readIncoming
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:112:  newConnection
        
        [chan receive]: $234, $110
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:364: (*Connection).manageQueue
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:113: newConnection
        
        [chan receive]: $235, $111
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection
        
        [chan receive]: $231
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve
        
        7 goroutines, 5 unique
FAIL
FAIL	golang.org/x/tools/internal/jsonrpc2_v2	3.674s

cc @ianthehat @findleyr @jba

@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 29, 2022
@heschi heschi added this to the Unreleased milestone Aug 29, 2022
@seankhliao seankhliao changed the title golang.org/x/tools/internal/jsonrpc2/servertest: TestServe is flaky on openbsd-386-68 x/tools/internal/jsonrpc2/servertest: TestServe is flaky on openbsd-386-68 Aug 30, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 30, 2022
@bcmills
Copy link
Contributor

bcmills commented Aug 30, 2022

This is jsonrpc2_v2, and it's closely related to the rest of the cluster of jsonrpc2_v2 concurrency bugs (such as #46520). I have a (rather large) stack of CLs that should fix it, but I've been having a hard time focusing enough to get that stack ready to merge. 😞

@bcmills bcmills self-assigned this Aug 30, 2022
@bcmills bcmills changed the title x/tools/internal/jsonrpc2/servertest: TestServe is flaky on openbsd-386-68 x/tools/internal/jsonrpc2_v2: TestServe is flaky on openbsd-386-68 Aug 30, 2022
@bcmills bcmills changed the title x/tools/internal/jsonrpc2_v2: TestServe is flaky on openbsd-386-68 x/tools/internal/jsonrpc2_v2: TestServe is flaky Aug 30, 2022
@bcmills
Copy link
Contributor

bcmills commented Aug 30, 2022

(The concurrency bugs reproduce more readily on OpenBSD, but they're present on all platforms and can be reproduced with a high enough -count.)

@mknyszek
Copy link
Contributor

mknyszek commented Sep 6, 2022

@rsc rsc changed the title x/tools/internal/jsonrpc2_v2: TestServe is flaky x/tools/internal/jsonrpc2_v2: TestServe failures Sep 20, 2022
@gopherbot
Copy link

gopherbot commented Sep 20, 2022

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/jsonrpc2_v2" && test == "TestServe"
2022-07-14 01:47 openbsd-386-68 tools@db8f89b3 go@a906d3dd x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.28s)
    --- FAIL: TestServe/tcp (0.10s)
        serve_test.go:137: close tcp 127.0.0.1:17864: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $197
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $30
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-07-14 01:47 openbsd-amd64-70 tools@db8f89b3 go@783ff7df x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.36s)
    --- FAIL: TestServe/tcp (0.15s)
        serve_test.go:137: close tcp 127.0.0.1:21044: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $211
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $144
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-07-15 14:27 openbsd-386-68 tools@1a4e02fe go@88a06f40 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.73s)
    --- FAIL: TestServe/tcp (0.20s)
        serve_test.go:137: close tcp 127.0.0.1:26211: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $229
        /tmp/workdir/go/src/runtime/netpoll.go:302:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:83:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:88:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $227
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-07-20 19:56 openbsd-amd64-68 tools@ec1f9244 go@076c3d7f x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.30s)
    --- FAIL: TestServe/tcp (0.12s)
        serve_test.go:137: close tcp 127.0.0.1:45900: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $188
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $214
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-07-25 14:31 openbsd-386-68 tools@6ec939a6 go@64f2829c x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.24s)
    --- FAIL: TestServe/tcp (0.12s)
        serve_test.go:137: close tcp 127.0.0.1:40864: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $221
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $219
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-03 12:09 openbsd-386-70 tools@ddb90ecd go@fcdd099a x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.78s)
    --- FAIL: TestServe/tcp (0.49s)
        serve_test.go:137: close tcp 127.0.0.1:23592: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $121
        /tmp/workdir/go/src/runtime/netpoll.go:302:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:83:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:88:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $119
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-03 18:07 openbsd-386-68 tools@d08f5dc9 go@f28fa952 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.43s)
    --- FAIL: TestServe/tcp (0.12s)
        serve_test.go:137: close tcp 127.0.0.1:30755: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $262
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $260
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-12 22:57 openbsd-386-70 tools@35f806b1 go@59865f14 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.50s)
    --- FAIL: TestServe/tcp (0.17s)
        serve_test.go:137: close tcp 127.0.0.1:8005: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $247
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $245
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-15 20:02 openbsd-386-70 tools@938e162b go@f80b1266 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.25s)
    --- FAIL: TestServe/tcp (0.12s)
        serve_test.go:137: close tcp 127.0.0.1:6489: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $231
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $229
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-26 17:59 openbsd-386-68 tools@717a6716 go@a1c9783c x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.96s)
    --- FAIL: TestServe/tcp (0.25s)
        serve_test.go:137: close tcp 127.0.0.1:42277: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $233
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $231
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-26 17:59 openbsd-386-68 tools@717a6716 go@7f92ccea x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.59s)
    --- FAIL: TestServe/tcp (0.19s)
        serve_test.go:137: close tcp 127.0.0.1:41710: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $263
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $261
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-29 18:21 openbsd-386-68 tools@248c34b8 go@ddc93a53 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.29s)
    --- FAIL: TestServe/tcp (0.27s)
        serve_test.go:137: close tcp 127.0.0.1:27746: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $128
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $126
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-08-31 21:10 openbsd-amd64-70 tools@550e1f5a go@86e9e0ea x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.60s)
    --- FAIL: TestServe/tcp (0.30s)
        serve_test.go:137: close tcp 127.0.0.1:33286: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $76
        /tmp/workdir/go/src/runtime/netpoll.go:305:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $244
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-09-02 00:49 openbsd-386-70 tools@33c1ddd5 go@6b555dc2 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.51s)
    --- FAIL: TestServe/tcp (0.12s)
        serve_test.go:137: close tcp 127.0.0.1:12373: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $160
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $218
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-09-02 19:58 openbsd-386-70 tools@d815cba5 go@2392b706 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.51s)
    --- FAIL: TestServe/tcp (0.15s)
        serve_test.go:137: close tcp 127.0.0.1:13046: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $263
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $261
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-09-07 17:33 openbsd-amd64-68 tools@5f27e050 go@dfdf5515 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.54s)
    --- FAIL: TestServe/tcp (0.38s)
        serve_test.go:137: close tcp 127.0.0.1:9128: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $221
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $219
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-09-07 18:17 openbsd-386-68 tools@3ee17105 go@dfdf5515 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (5.16s)
    --- FAIL: TestServe/tcp (5.01s)
        serve_test.go:109: context deadline exceeded
        serve_test.go:137: close tcp 127.0.0.1:27430: use of closed network connection
    --- FAIL: TestServe/pipe (0.00s)
        serve_test.go:109: context deadline exceeded
        serve_test.go:140: context deadline exceeded
2022-09-07 22:05 linux-s390x-ibm tools@a6307518 go@29604312 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.27s)
    --- FAIL: TestServe/tcp (0.15s)
        serve_test.go:137: close tcp 127.0.0.1:38903: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $245
        /data/golang/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /data/golang/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /data/golang/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /data/golang/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /data/golang/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $243
        /data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /data/golang/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-09-13 15:21 openbsd-386-70 tools@9250e22a go@585c4386 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.51s)
    --- FAIL: TestServe/tcp (0.15s)
        serve_test.go:137: close tcp 127.0.0.1:25190: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $232
        /tmp/workdir/go/src/runtime/netpoll.go:306:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:84:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:89:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $253
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique
2022-09-19 18:18 linux-ppc64-buildlet tools@fdf581fd go@31d06b58 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (0.25s)
    --- FAIL: TestServe/tcp (0.22s)
        serve_test.go:104: dial tcp 127.0.0.1:43987: connect: connection refused
2022-09-19 18:40 openbsd-386-68 tools@15782446 go@31d06b58 x/tools/internal/jsonrpc2_v2.TestServe (log)
--- FAIL: TestServe (1.59s)
    --- FAIL: TestServe/tcp (0.19s)
        serve_test.go:137: close tcp 127.0.0.1:11325: use of closed network connection
    stacktest.go:48: goroutine leak detected:
        [IO wait]: $247
        /tmp/workdir/go/src/runtime/netpoll.go:302:                                   runtime_pollWait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:83:                      (*pollDesc).wait
        /tmp/workdir/go/src/internal/poll/fd_poll_runtime.go:88:                      (*pollDesc).waitRead
        /tmp/workdir/go/src/internal/poll/fd_unix.go:167:                             (*FD).Read
        /tmp/workdir/go/src/net/fd_posix.go:55:                                       (*netFD).Read
...
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:399: (*Connection).deliverMessages
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:114: newConnection

        [chan receive]: $245
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/jsonrpc2.go:113: (*async).wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/conn.go:270:     (*Connection).Wait
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:115:    (*Server).run
        /tmp/workdir/gopath/src/golang.org/x/tools/internal/jsonrpc2_v2/serve.go:72:     Serve

        7 goroutines, 5 unique

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Oct 31, 2022

This should be fixed as of CL 443678 or earlier.

@bcmills bcmills closed this as completed Oct 31, 2022
@golang golang locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

4 participants