Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/build_overlay broken when gccgo is present as of CL 421879 #54761

Closed
bcmills opened this issue Aug 29, 2022 · 5 comments
Closed

cmd/go: TestScript/build_overlay broken when gccgo is present as of CL 421879 #54761

bcmills opened this issue Aug 29, 2022 · 5 comments
Assignees
@ianlancetaylor @bcmills
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.20

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2022

https://go.dev/cl/421879 caused go build --compiler=gccgo to fail when the installed gccgo predates the runtime/cgo changes in that CL.

I'm not sure what exactly, if anything, we should do about that, since we can't in general make assumptions about which gccgo the user may have installed.

@ianlancetaylor, @cuonglm: any suggestions? (For now I'm going to disable that part of the test.)
@bcmills bcmills added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 29, 2022
@bcmills bcmills added this to the Go1.20 milestone Aug 29, 2022
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 29, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/426496 mentions this issue: cmd/go: skip gccgo cgo tests in TestScript/build_overlay

gopherbot pushed a commit that referenced this issue Aug 29, 2022
@gopherbot
cmd/go: skip gccgo cgo tests in TestScript/build_overlay
6553558 
cgo builds with -compiler=gccgo are broken as of CL 421879.

For #54761.
Updates #46731.

Change-Id: I0306b0bd96669f70279fc96814cc72d934a1ad6e
Reviewed-on: https://go-review.googlesource.com/c/go/+/426496
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/426155 mentions this issue: cmd/cgo: use //go:notinheap if building with gccgo

@ianlancetaylor
Copy link
Contributor

For the record, while I haven't looked at this specific issue yet, the general goal is for cmd/go to test what gccgo features are supported, and use those.

@bcmills
Copy link
Contributor Author

bcmills commented Sep 20, 2022

That makes sense. Perhaps at some point after https://go.dev/cl/420054 lands we should add a script condition for gccgo features in script tests?

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/446260 mentions this issue: cmd/go, cmd/cgo: support older versions of gccgo that lack cgo.Incomplete

romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
@ianlancetaylor @romaindoumenc
cmd/go, cmd/cgo: support older versions of gccgo that lack cgo.Incomp…
d9997f9 
…lete

Test whether gccgo/GoLLVM supports cgo.Incomplete. If it doesn't, use a
local definition rather than importing it.

Roll back 426496, which skipped a gccgo test, as it now works.

For golang#46731
Fixes golang#54761

Change-Id: I8bb2ad84c317094495405e178bf5c9694f82af56
Reviewed-on: https://go-review.googlesource.com/c/go/+/446260
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianlancetaylor ianlancetaylor

@bcmills bcmills

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@ianlancetaylor @bcmills @gopherbot