Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: runtime.firstmoduledata: missing xsym in relocation on AIX #54814

Closed
cuonglm opened this issue Sep 1, 2022 · 6 comments
Closed

cmd/link: runtime.firstmoduledata: missing xsym in relocation on AIX #54814

cuonglm opened this issue Sep 1, 2022 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX
Milestone

Comments

@cuonglm
Copy link
Member

cuonglm commented Sep 1, 2022

What version of Go are you using (go version)?

$ go version
tip

Does this issue reproduce with the latest release?

N/A

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

go run run.go -- fixedbugs/issue42032.go

What did you expect to see?

Test passes

What did you see instead?

Test failed: https://build.golang.org/log/fdb5399c8575237752fd316a7d8fa97dc712e5d6

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 1, 2022
@cuonglm cuonglm added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed compiler/runtime Issues related to the Go compiler and/or runtime. labels Sep 1, 2022
@cuonglm
Copy link
Member Author

cuonglm commented Sep 1, 2022

cc @cherrymui @thanm

@gopherbot
Copy link

gopherbot commented Sep 1, 2022

Change https://go.dev/cl/427394 mentions this issue: go/types,types2: exclude tests that need cgo.Incomplete

@bcmills bcmills added the OS-AIX label Sep 1, 2022
@bcmills
Copy link
Member

bcmills commented Sep 1, 2022

(CC @golang/aix)

@bcmills bcmills added this to the Go1.20 milestone Sep 1, 2022
gopherbot pushed a commit that referenced this issue Sep 1, 2022
Since when go/types,types2 do not know about build constraints, and
runtime/cgo.Incomplete is only available on platforms that support cgo.

These tests are also failing on aix with failure from linker, so disable
them on aix to make builder green. The fix for aix is tracked in #54814

Updates #46731
Updates #54814

Change-Id: I5d6f6e29a8196efc6c457ea64525350fc6b20309
Reviewed-on: https://go-review.googlesource.com/c/go/+/427394
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
@cherrymui
Copy link
Member

cherrymui commented Sep 1, 2022

go run issue42032.go works on AIX. But the special "compile+link" recipe from test/run.go https://cs.opensource.google/go/go/+/master:test/run.go;l=1141 fails. The reason is that it doesn't pass the -buildid linker flag, yet we're adding a reference togo:buildid symbol (which assumes the symbol exists). Sending a CL to fix.

@gopherbot
Copy link

gopherbot commented Sep 1, 2022

Change https://go.dev/cl/427620 mentions this issue: cmd/link: only add dummy XCOFF reference if the symbol exists

@mknyszek
Copy link
Contributor

mknyszek commented Sep 6, 2022

Saw a couple failures like

2022-09-01T00:42:27-64b260d/aix-ppc64

in triage, but I'm going to guess it's fixed because I only saw them early in the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX
Projects
None yet
Development

No branches or pull requests

5 participants