Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln/cmd/govulncheck: document the default cache location #54829

Closed
hyangah opened this issue Sep 2, 2022 · 3 comments
Closed

x/vuln/cmd/govulncheck: document the default cache location #54829

hyangah opened this issue Sep 2, 2022 · 3 comments
Assignees
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 2, 2022

Currently, govulncheck creates a local cache under $GOPATH/pkg/mod/cache/download/vulndb.
Document this - I had old data in this cache (before the spec change) which prevented the newly built govulncheck from working correctly.

Related questions:

  • Is there any way to set a different location than a subdirectory?
  • Is deleting the directory the recommended best practice when users want to fix corrupted/outdated cache problems? Or should we use a variation of go clean?
@gopherbot gopherbot added this to the Unreleased milestone Sep 2, 2022
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Sep 2, 2022
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 2, 2022
@heschi
Copy link
Contributor

heschi commented Sep 2, 2022

cc @golang/vulndb

@julieqiu julieqiu added vulncheck or vulndb Issues for the x/vuln or x/vulndb repo and removed x/vuln labels Sep 2, 2022
@julieqiu julieqiu removed the x/vuln label Sep 2, 2022
@julieqiu julieqiu modified the milestones: Unreleased, vuln/2022 Sep 6, 2022
@zpavlinovic
Copy link
Contributor

zpavlinovic commented Sep 6, 2022

Although we expect spec to converge at some point, we should have a story for this. Would ideally this be done automatically, e.g., refetch if the spec has changed? Or you'd like more control via, say, GOVULNDBCACHE flag?

@julieqiu julieqiu modified the milestones: vuln/2022, vuln/unplanned Apr 7, 2023
@zpavlinovic zpavlinovic self-assigned this Feb 8, 2024
@zpavlinovic
Copy link
Contributor

The new design of the db does not use cache, so this is obsolete now.

@golang golang locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Status: Done
Development

No branches or pull requests

5 participants