Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cleanup fixedbugs/notinheap.go #54846

Open
cuonglm opened this issue Sep 2, 2022 · 1 comment
Open

test: cleanup fixedbugs/notinheap.go #54846

cuonglm opened this issue Sep 2, 2022 · 1 comment
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@cuonglm
Copy link
Member

cuonglm commented Sep 2, 2022

After #46731, //go:notinheap is gone, however, there's still test/fixedbugs/notinheap.go which is using it. There's no problem with trybot, because the file is ignored:

go/test/run.go

Line 1975 in 34f0029

"fixedbugs/notinheap.go", // types2 doesn't report errors about conversions that are invalid due to //go:notinheap

We should revise those test cases:

  • Writing the equivalent ones, replacing //go:notinheap by cgo.Incomplete.
  • Remove the file entirely.

cc @mdempsky @randall77

@cuonglm cuonglm self-assigned this Sep 2, 2022
@cuonglm cuonglm added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 2, 2022
@cuonglm cuonglm added this to the Go1.20 milestone Sep 2, 2022
@cuonglm
Copy link
Member Author

cuonglm commented Sep 2, 2022

Taking a quick look, not all the cases can be rewrite, for example, there's no thing like this anymore:

//go:notinheap
type t3 byte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

1 participant